Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965560Ab3DPWhL (ORCPT ); Tue, 16 Apr 2013 18:37:11 -0400 Received: from ganesha.gnumonks.org ([213.95.27.120]:39417 "EHLO ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965426Ab3DPWhJ (ORCPT ); Tue, 16 Apr 2013 18:37:09 -0400 X-Greylist: delayed 965 seconds by postgrey-1.27 at vger.kernel.org; Tue, 16 Apr 2013 18:37:08 EDT Date: Wed, 17 Apr 2013 00:20:37 +0200 From: Harald Welte To: David Howells Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, netfilter-devel@vger.kernel.org, viro@zeniv.linux.org.uk, Jan Engelhardt Subject: Re: [PATCH 24/28] proc: Supply an accessor to get the name in a proc_dir_entry struct [RFC] Message-ID: <20130416222037.GR5785@prithivi.gnumonks.org> References: <20130416182550.27773.89310.stgit@warthog.procyon.org.uk> <20130416182725.27773.42175.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130416182725.27773.42175.stgit@warthog.procyon.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1418 Lines: 31 Hi David, On Tue, Apr 16, 2013 at 07:27:25PM +0100, David Howells wrote: > This is only needed by the xt_hashlimit netfilter module as that appears to > use the name in the pde to save a label in the xt_hashlimit_htable struct - > which will be a problem if CONFIG_PROC_FS=n. I don't know the larger context of this patch (and am not follwing filesystem related work in general), but at least from the xt_hashlimit point of view this of course looks fine. We can always wrap direct accesses to structure members behind an API call. For consistency reasons 'proc_get_name()' might be a better name than get_proc_name(), but that's probably a matter of taste. Pleaes note that I'm only the original author but not the active maintainer of the xt_hashlimit (formerly ipt_hashlimit) code. Regards, Harald -- - Harald Welte http://netfilter.org/ ============================================================================ "Fragmentation is like classful addressing -- an interesting early architectural error that shows how much experimentation was going on while IP was being designed." -- Paul Vixie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/