Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752200Ab3DPX6A (ORCPT ); Tue, 16 Apr 2013 19:58:00 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:36266 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966Ab3DPX57 (ORCPT ); Tue, 16 Apr 2013 19:57:59 -0400 Date: Tue, 16 Apr 2013 16:57:51 -0700 From: Greg KH To: Kent Yoder Cc: Duncan Laurie , Dirk Hohndel , Kent Yoder , Luigi Semenzato , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH] TPM: Retry SaveState command in suspend path Message-ID: <20130416235751.GA9531@kroah.com> References: <1363557399-11822-1-git-send-email-dlaurie@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1612 Lines: 39 On Tue, Mar 19, 2013 at 10:00:02AM -0500, Kent Yoder wrote: > Hi Duncan, > > On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie wrote: > > If the TPM has already been sent a SaveState command before the driver > > is loaded it may have problems sending that same command again later. > > > > This issue is seen with the Chromebook Pixel due to a firmware bug in > > the legacy mode boot path which is sending the SaveState command > > before booting the kernel. More information is available at > > http://crbug.com/203524 > > > > This change introduces a retry of the SaveState command in the suspend > > path in order to work around this issue. A future firmware update > > should fix this but this is also a trivial workaround in the driver > > that has no effect on systems that do not show this problem. > > I'm not convinced that this needs to be upstream. The simplest > route would seem to be to carry this out of tree until your firmware > is fixed. Really? We have machines that we are using right now that need this fix in order to work properly. The kernel handles buggy firmware/bioses all the time, we need to work properly on all hardware, we can't count on a firmware update ever getting pushed out publically, and for those of us using this hardware, we want it to work. So, please accept this patch, thanks, greg l-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/