Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752467Ab3DQAA6 (ORCPT ); Tue, 16 Apr 2013 20:00:58 -0400 Received: from mail-da0-f42.google.com ([209.85.210.42]:46205 "EHLO mail-da0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992Ab3DQAAz (ORCPT ); Tue, 16 Apr 2013 20:00:55 -0400 Message-ID: <516DE62E.8020905@gmail.com> Date: Wed, 17 Apr 2013 08:00:46 +0800 From: Jiang Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: David Rientjes CC: Bjorn Helgaas , "Rafael J . Wysocki" , Jiang Liu , Yinghai Lu , Yijing Wang , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Greg Kroah-Hartman , ACPI Devel Maling List , Toshi Kani , Myron Stowe , "Rafael J. Wysocki" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org Subject: Re: [PATCH v9 09/16] PCI, x86: implement pcibios_{add|remove}_bus() hooks References: <1365781470-32379-1-git-send-email-jiang.liu@huawei.com> <1365781470-32379-10-git-send-email-jiang.liu@huawei.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1726 Lines: 53 On 04/17/2013 04:27 AM, David Rientjes wrote: > On Fri, 12 Apr 2013, Jiang Liu wrote: > >> diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c >> index 901177d..305c68b 100644 >> --- a/arch/x86/pci/common.c >> +++ b/arch/x86/pci/common.c >> @@ -6,6 +6,7 @@ >> >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -170,6 +171,16 @@ void pcibios_fixup_bus(struct pci_bus *b) >> pcibios_fixup_device_resources(dev); >> } >> >> +void pcibios_add_bus(struct pci_bus *bus) >> +{ >> + acpi_pci_add_bus(bus); >> +} >> + >> +void pcibios_remove_bus(struct pci_bus *bus) >> +{ >> + acpi_pci_remove_bus(bus); >> +} >> + >> /* >> * Only use DMI information to set this if nothing was passed >> * on the kernel command line (which was parsed earlier). > > This causes build errors when CONFIG_ACPI isn't enabled since both > acpi_pci_{add,remove}_bus() aren't defined in such a configuration: > > arch/x86/pci/common.c: In function 'pcibios_add_bus': > arch/x86/pci/common.c:176:2: error: implicit declaration of function 'acpi_pci_add_bus' > arch/x86/pci/common.c: In function 'pcibios_remove_bus': > arch/x86/pci/common.c:181:2: error: implicit declaration of function 'acpi_pci_remove_bus' > Hi David, Thanks for report, I have sent a patch to Bjorn to fix this issue, and it should have been fixed in Bjorn's git tree. Regards! Gerry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/