Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755760Ab3DQAwi (ORCPT ); Tue, 16 Apr 2013 20:52:38 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:22556 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754273Ab3DQAwh (ORCPT ); Tue, 16 Apr 2013 20:52:37 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/7Ln7ORT83SEaTl2zaO65c Date: Tue, 16 Apr 2013 17:52:32 -0700 From: Tony Lindgren To: Roger Quadros Cc: b-cousson@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: omap3-beagle-xm: Add USB Host support for Rev Ax/Bx Message-ID: <20130417005232.GV10155@atomide.com> References: <1366029306-1824-1-git-send-email-rogerq@ti.com> <516BF4F3.5060904@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <516BF4F3.5060904@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2185 Lines: 63 * Roger Quadros [130415 05:44]: > On 04/15/2013 03:35 PM, Roger Quadros wrote: > > Provide RESET and Power regulators for the USB PHY, > > the USB Host port mode and the PHY device. > > > > Also provide pin multiplexer information for USB host > > pins. > > > > This will not work for Rev Cx boards because of reversed logic > > for USB_POWER_Enable. > > > > CC: Benoît Cousson > > Signed-off-by: Roger Quadros > > --- > > arch/arm/boot/dts/omap3-beagle-xm.dts | 62 +++++++++++++++++++++++++++++++++ > > 1 files changed, 62 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts > > index 5a31964..d394c51 100644 > > --- a/arch/arm/boot/dts/omap3-beagle-xm.dts > > +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts > > @@ -57,6 +57,60 @@ > > ti,mcbsp = <&mcbsp2>; > > ti,codec = <&twl_audio>; > > }; > > + > > + /* HS USB Port 2 RESET */ > > + hsusb2_reset: hsusb2_reset_reg { > > + compatible = "regulator-fixed"; > > + regulator-name = "hsusb2_reset"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpio = <&gpio5 19 0>; /* gpio_147 */ > > + startup-delay-us = <70000>; > > + enable-active-high; > > + }; > > + > > + /* HS USB Port 2 Power */ > > + hsusb2_power: hsusb2_power_reg { > > + compatible = "regulator-fixed"; > > + regulator-name = "hsusb2_vbus"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpio = <&twl_gpio 18 0>; /* GPIO LEDA */ > > + startup-delay-us = <70000>; > > + enable-active-high; /* FIXME: active-low for Rev. C */ > > Benoit & Tony, > > Any ideas how to tackle the reversed logic for Rev. C boards? Sounds like we need a shared omap3-beage.dtsi, then omap3-beagle-xm.dts and omap3-beagle-rev-c.dts. Then xm and rev-c can both include the common .dtsi. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/