Date: Wed, 17 Apr 2013 12:08:10 +0200
From: Michael Braun <michael-dev@fami-braun.de>
To: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Cc: Alan Stern <stern@rowland.harvard.edu>, projekt-wlan@fem.tu-ilmenau.de,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Regression in 3735ba8db8e6ea22ad3ff524328926d8d780a884 with
 Freescale P1020
Message-ID: <20130417100809.GA8855@dynamic.fami-braun.de>
Reply-To: projekt-wlan@fem.tu-ilmenau.de
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1376
Lines: 24

Hi,

I'm running OpenWRT Kernel 3.8.3 (which already has f66dea709cd9309b2ee9f715697818001fb518de and 5ed338778f917a035f0f0a52327fc4f72e36f7a1 applied) on a P1020WLAN (QorlQ, PPC) device.
Before updating the kernel from 3.3.0, USB host support was working fine. Now I get "fsl-ehci: USB PHY clock invalid" messages in dmesg and the lsusb output is empty, so USB host support is not working. When I apply the following patch, USB host support starts working again, so I guess 3735ba8db8e6ea22ad3ff524328926d8d780a884 is the cause.
Do you have an idea how to fix it more appropriately?

Thanks,
  M. Braun

--- a/drivers/usb/host/ehci-fsl.c       2013-04-15 21:13:52.924403077 +0200
+++ b/drivers/usb/host/ehci-fsl.c       2013-04-15 21:13:57.572410838 +0200
@@ -273,7 +273,6 @@ static int ehci_fsl_setup_phy(struct usb
                 if (!spin_event_timeout(in_be32(non_ehci + FSL_SOC_USB_CTRL) &
                                 PHY_CLK_VALID, FSL_USB_PHY_CLK_TIMEOUT, 0)) {
                         printk(KERN_WARNING "fsl-ehci: USB PHY clock invalid\n");
-                       return -EINVAL;
                 }
         }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/