MIME-version: 1.0
Content-transfer-encoding: 8BIT
Content-type: text/plain; charset=UTF-8
Message-id: <516E7DED.8090905@samsung.com>
Date: Wed, 17 Apr 2013 12:48:13 +0200
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
To: =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= <heiko@sntech.de>
Cc: linus.walleij@linaro.org, grant.likely@secretlab.ca,
        kyungmin.park@samsung.com, kgene.kim@samsung.com,
        linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
        Thomas Abraham <thomas.abraham@linaro.org>
Subject: Re: [PATCH 1/2] gpio: samsung: Remove OF support for s3c24xx
References: <1366134094-23140-1-git-send-email-s.nawrocki@samsung.com>
 <201304162013.45134.heiko@sntech.de>
In-reply-to: <201304162013.45134.heiko@sntech.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1740
Lines: 44

On 04/16/2013 08:13 PM, Heiko Stübner wrote:
> Am Dienstag, 16. April 2013, 19:41:34 schrieb Sylwester Nawrocki:
>> There is no users of this code and there is already a pinctrl
>> driver written for s3c24xx which is going to be used on any
>> s3c24xx DT platforms. Hence this has been effectively a dead
>> code in mainline.
>>
>> This reverts commit 172c6a13653ac8cd6a231293b87c93821e90c1d6
>> gpio: samsung: add devicetree init for s3c24xx arches
>>
>> Cc: Heiko Stübner <heiko@sntech.de>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> 
> This patch stems from a time where I thought pinctrl on s3c24xx would be ages 
> away :-D, so

Heh, I just thought I would clean this up a bit. And now we have
a nice pinctrl driver for s3c24xx. 

As a side note, I've tried it on s3c2440, together with your patch 
series adding dt support for s3c2416. Need to resolve a couple more
issues and hopefully will have a booting system soon.

> Acked-by: Heiko Stuebner <heiko@sntech.de>

Thanks.

I abstained with posting the second patch, which removes Exynos4/5 OF 
support from the gpio-samsung driver. Now when those platforms have 
proper pinctrl driver it is not possible to support simultaneously 
the old (pre-eliminary) DT bindings and the standard GPIO bindings 
implemented by the pinctrl driver. Anyway I have it prepared so I'll
post it, at least it might be a starting point for a discussion.


Thanks,
Sylwester

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/