Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966059Ab3DQL1M (ORCPT ); Wed, 17 Apr 2013 07:27:12 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:27791 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965132Ab3DQL1K (ORCPT ); Wed, 17 Apr 2013 07:27:10 -0400 X-Authority-Analysis: v=2.0 cv=aOZyWMBm c=1 sm=0 a=ofFxtc/jepklO3aWSWiKGA==:17 a=99CFIlhQ8dUA:10 a=XqBCkJwx3yUA:10 a=bIxKA6TX_asA:10 a=vQlp3vXYDpMA:10 a=8nJEP1OIZ-IA:10 a=2KX_Yc5PAAAA:8 a=fkMt6HFWGF8A:10 a=kKAx9GwCrhY_jL7OA4QA:9 a=wPNLvfGTeEIA:10 a=ofFxtc/jepklO3aWSWiKGA==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 70.112.99.80 Message-ID: <516E870B.5010303@tabi.org> Date: Wed, 17 Apr 2013 06:27:07 -0500 From: Timur Tabi User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:20.0) Gecko/20100101 Firefox/20.0 SeaMonkey/2.17.1 MIME-Version: 1.0 To: Tang Yuantian-B29983 CC: Grant Likely , devicetree-discuss , "linuxppc-dev@lists.ozlabs.org" , lkml , Rob Herring Subject: Re: [PATCH v2] of/base: release the node correctly in of_parse_phandle_with_args() References: <1365564999-24427-1-git-send-email-Yuantian.Tang@freescale.com> <516E1763.7040206@tabi.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 472 Lines: 14 Tang Yuantian-B29983 wrote: > It was placed on ELSE statement originally, I moved it to IF statement. > Why is it so wrong? Because the logic of the comment applies to the else-condition, not the if-condtion. -- Timur Tabi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/