Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966149Ab3DQLfI (ORCPT ); Wed, 17 Apr 2013 07:35:08 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:51439 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965979Ab3DQLfE (ORCPT ); Wed, 17 Apr 2013 07:35:04 -0400 From: Sourav Poddar To: , , , CC: , , , Sourav Poddar , Benoit Cousson , Santosh Shilimkar , Felipe Balbi , Rajendra nayak Subject: [PATCH 5/6] arm: dts: am33xx: Remove "ti,no_idle_on_suspend" property. Date: Wed, 17 Apr 2013 17:04:26 +0530 Message-ID: <1366198467-6757-6-git-send-email-sourav.poddar@ti.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1366198467-6757-1-git-send-email-sourav.poddar@ti.com> References: <1366198467-6757-1-git-send-email-sourav.poddar@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2081 Lines: 57 The "ti,no_idle_on_suspend" property was required to keep ocmcram clocks running during idle. But the commit below[1], added in v3.6 should prevent the any automaic clock gating for devices without drivers bound. Since there is no driver for the OCM RAM block, we are not affected by the automatic idle on suspend anyways. [1]: commit 72bb6f9b51c82c820ddef892455a85b115460904 Author: Kevin Hilman Date: Tue Jul 10 15:29:04 2012 -0700 ARM: OMAP: omap_device: don't attempt late suspend if no driver bound Currently, the omap_device PM domain layer uses the late suspend and early resume callbacks to ensure devices are in their low power states. However, this is attempted even in cases where a driver probe has failed. If a driver's ->probe() method fails, the driver is likely in a state where it is not expecting its runtime PM callbacks to be called, yet currently the omap_device PM domain code attempts to call the drivers callbacks. To fix, use the omap_device driver_status field to check whether a driver is bound to the omap_device before attempting to trigger driver callbacks. Cc: Benoit Cousson Cc: Santosh Shilimkar Cc: Felipe Balbi Cc: Rajendra nayak Signed-off-by: Sourav Poddar --- arch/arm/boot/dts/am33xx.dtsi | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 74a8125..49a050e 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -394,7 +394,6 @@ compatible = "ti,am3352-ocmcram"; reg = <0x40300000 0x10000>; ti,hwmods = "ocmcram"; - ti,no_idle_on_suspend; }; wkup_m3: wkup_m3@44d00000 { -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/