Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966694Ab3DQOjp (ORCPT ); Wed, 17 Apr 2013 10:39:45 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:36103 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966466Ab3DQOjo (ORCPT ); Wed, 17 Apr 2013 10:39:44 -0400 Message-ID: <1366209583.28609.35.camel@joe-AO722> Subject: Re: [PATCH] usb: storage: Add usb_stor_dbg, reduce object size From: Joe Perches To: Alan Stern Cc: Matthew Dharm , Greg Kroah-Hartman , linux-usb , usb-storage , LKML Date: Wed, 17 Apr 2013 07:39:43 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.2-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 31 On Wed, 2013-04-17 at 10:14 -0400, Alan Stern wrote: > On Tue, 16 Apr 2013, Joe Perches wrote: > > Reduce the size of the objects by consolidating > > the duplicated USB_STORAGE into a single function. [] > Is there any reasonable way to change this so that US_DEBUGP gets > converted to a dev_dbg call instead of a printk call? Not including > the device identifier in the output can be a real problem if there are > multiple mass-storage devices in the system. No. There's no standardized name of a struct device *. struct us_data *us exists for most of them but not all. Some have a struct isd_200 *info available, other don't have a struct device * at all. Some or all US_DEBUGP calls would have to change form. Perhaps a good patch would be to convert US_DEBUGP calls where a struct us_data * is available to to us_stor_dbg(struct us_data *, const char *fmt, ...) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/