Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966719Ab3DQPKt (ORCPT ); Wed, 17 Apr 2013 11:10:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41943 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966551Ab3DQPKs (ORCPT ); Wed, 17 Apr 2013 11:10:48 -0400 Date: Wed, 17 Apr 2013 17:10:42 +0200 From: Andrea Arcangeli To: "Kirill A. Shutemov" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim Subject: Re: [PATCH] thp: fix huge zero page logic for page with pfn == 0 Message-ID: <20130417151041.GA25659@redhat.com> References: <1366211253-14325-1-git-send-email-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366211253-14325-1-git-send-email-kirill.shutemov@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1039 Lines: 23 On Wed, Apr 17, 2013 at 06:07:33PM +0300, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > Current implementation of huge zero page uses pfn value 0 to indicate > that the page hasn't allocated yet. It assumes that buddy page allocator > can't return page with pfn == 0. > > Let's rework the code to store 'struct page *' of huge zero page, not > its pfn. This way we can avoid the weak assumption. > > Signed-off-by: Kirill A. Shutemov > Reported-by: Minchan Kim > Acked-by: Minchan Kim > --- > mm/huge_memory.c | 43 +++++++++++++++++++++---------------------- > 1 file changed, 21 insertions(+), 22 deletions(-) Reviewed-by: Andrea Arcangeli -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/