Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758348Ab3DQT2n (ORCPT ); Wed, 17 Apr 2013 15:28:43 -0400 Received: from g5t0009.atlanta.hp.com ([15.192.0.46]:32758 "EHLO g5t0009.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756126Ab3DQT2l (ORCPT ); Wed, 17 Apr 2013 15:28:41 -0400 Message-ID: <516EF7E4.3070701@hp.com> Date: Wed, 17 Apr 2013 15:28:36 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120601 Thunderbird/10.0.5 MIME-Version: 1.0 To: Ingo Molnar CC: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "Paul E. McKenney" , David Howells , Dave Jones , Clark Williams , Peter Zijlstra , linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, "Chandramouleeswaran, Aswin" , Davidlohr Bueso , "Norton, Scott J" , Rik van Riel Subject: Re: [PATCH v3 5/5] mutex: Move mutex spinning code from sched/core.c back to mutex.c References: <1366172891-7729-1-git-send-email-Waiman.Long@hp.com> <1366172891-7729-6-git-send-email-Waiman.Long@hp.com> <20130417071827.GB21051@gmail.com> In-Reply-To: <20130417071827.GB21051@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1417 Lines: 32 On 04/17/2013 03:18 AM, Ingo Molnar wrote: > * Waiman Long wrote: > >> As mentioned by Ingo, the SCHED_FEAT_OWNER_SPIN scheduler feature >> bit was really just an early hack to make with/without mutex-spinning >> testable. So it is no longer necessary. >> >> This patch removes the SCHED_FEAT_OWNER_SPIN feature bit and move the >> mutex spinning code from kernel/sched/core.c back to kernel/mutex.c >> which is where they should belong. >> >> Signed-off-by: Waiman Long >> --- >> include/linux/sched.h | 4 --- >> kernel/mutex.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++ >> kernel/sched/core.c | 63 ----------------------------------------------- >> kernel/sched/features.h | 7 ----- >> 4 files changed, 62 insertions(+), 74 deletions(-) > Please move this patch first in the series - so that later, functional patches are > easier to revert, should the need arise. When possible we sort patches by risk: > low risk ones first, riskier come later. I have sent out a new series (v4) with the requested changes. Please let me know what else do you think I need to do. Regards, Longman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/