Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966385Ab3DQUPh (ORCPT ); Wed, 17 Apr 2013 16:15:37 -0400 Received: from relay2.sgi.com ([192.48.179.30]:58076 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752436Ab3DQUPe (ORCPT ); Wed, 17 Apr 2013 16:15:34 -0400 Date: Wed, 17 Apr 2013 15:15:33 -0500 From: Robin Holt To: "H. Peter Anvin" Cc: Robin Holt , Ingo Molnar , "Srivatsa S. Bhat" , Russ Anderson , Linux Kernel Mailing List , the arch/x86 maintainers Subject: Re: [PATCH -v5 5/5] Make reboot_cpuid a kernel parameter. Message-ID: <20130417201533.GL3658@sgi.com> References: <1366224198-49485-1-git-send-email-holt@sgi.com> <1366224198-49485-6-git-send-email-holt@sgi.com> <516EF9DE.6000707@zytor.com> <20130417194836.GK3658@sgi.com> <516EFF3D.4040506@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <516EFF3D.4040506@zytor.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 25 On Wed, Apr 17, 2013 at 12:59:57PM -0700, H. Peter Anvin wrote: > It is also worth noting that the documentation says reboot=s[mp]# > whereas in fact only reboot=s# parse correctly. I consider this to be a > bug. > > If we centralized the parser, we could take a string like > > "reboot=bios,smp32,warm" > > and parse it into: > > reboot_cpu = 32 > reboot_mode = "bw" > > ... and pass the information in that form to the arch layer. I don't > think we can do more parsing at that in the main kernel. OK. I will go back to the drawing board again. Robin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/