Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966856Ab3DQVbR (ORCPT ); Wed, 17 Apr 2013 17:31:17 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:37240 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965687Ab3DQVbO (ORCPT ); Wed, 17 Apr 2013 17:31:14 -0400 MIME-Version: 1.0 In-Reply-To: <201304172328.01071.arnd@arndb.de> References: <201304171115.51509.arnd@arndb.de> <201304172328.01071.arnd@arndb.de> Date: Wed, 17 Apr 2013 14:31:13 -0700 X-Google-Sender-Auth: GbDt2dYvKA3_3oCXaSK_-FjYcGM Message-ID: Subject: Re: Device driver memory 'mmap()' function helper cleanup From: Linus Torvalds To: Arnd Bergmann Cc: Linux Kernel Mailing List , Clemens Ladisch , Takashi Iwai , Mauro Carvalho Chehab Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 521 Lines: 14 On Wed, Apr 17, 2013 at 2:28 PM, Arnd Bergmann wrote: > > There is a separate check for the physical address that gets > mapped in hpet_mmap: Ahh, right you are. The earlier check for PAGE_SIZE's mapping and zero offset is indeed superfluous. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/