Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965233Ab3DRDNC (ORCPT ); Wed, 17 Apr 2013 23:13:02 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:51523 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965101Ab3DRDNA (ORCPT ); Wed, 17 Apr 2013 23:13:00 -0400 MIME-Version: 1.0 Date: Thu, 18 Apr 2013 11:12:59 +0800 Message-ID: Subject: [PATCH -next] ALSA: hda - fix error return code in patch_alc662() From: Wei Yongjun To: perex@perex.cz, tiwai@suse.de, david.henningsson@canonical.com, kailang@realtek.com Cc: yongjun_wei@trendmicro.com.cn, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 30 From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Signed-off-by: Wei Yongjun --- sound/pci/hda/patch_realtek.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index f15c36b..a3965b0 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -3787,7 +3787,8 @@ static int patch_alc662(struct hda_codec *codec) if ((alc_get_coef0(codec) & (1 << 14)) && codec->bus->pci->subsystem_vendor == 0x1025 && spec->cdefine.platform_type == 1) { - if (alc_codec_rename(codec, "ALC272X") < 0) + err = alc_codec_rename(codec, "ALC272X"); + if (err < 0) goto error; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/