Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965459Ab3DRDcO (ORCPT ); Wed, 17 Apr 2013 23:32:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22981 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965198Ab3DRDcM (ORCPT ); Wed, 17 Apr 2013 23:32:12 -0400 Message-ID: <516F6834.9030100@redhat.com> Date: Thu, 18 Apr 2013 11:27:48 +0800 From: Lingzhu Xiang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Luis Henriques CC: Andy Whitcroft , Matt Fleming , Josh Boyer , "linux-kernel@vger.kernel.org" , stable@vger.kernel.org, "Lee, Chun-Yi" , "kernel-team@lists.ubuntu.com" , Seiji Aguchi , Michael Schroeder Subject: Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName References: <1365414657-29191-98-git-send-email-luis.henriques@canonical.com> <1365547506.5814.36.camel@deadeye.wl.decadent.org.uk> <51653E81.4090102@redhat.com> <20130410121730.GB3049@hercules> <20130411091256.GA11370@hercules> <20130416103321.GB3054@hercules> <516E2717.3020309@redhat.com> <20130417115641.GG15755@dm> <516E9205.3070200@redhat.com> <20130417132858.GA5577@hercules> In-Reply-To: <20130417132858.GA5577@hercules> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2318 Lines: 50 On 04/17/2013 09:28 PM, Luis Henriques wrote: > On Wed, Apr 17, 2013 at 08:13:57PM +0800, Lingzhu Xiang wrote: >> On 04/17/2013 07:56 PM, Andy Whitcroft wrote: >>> On Wed, Apr 17, 2013 at 12:37:43PM +0800, Lingzhu Xiang wrote: >>>> On 04/16/2013 06:33 PM, Luis Henriques wrote: >>>>> 68d929862e29a8b52a7f2f2f86a0600423b093cd efi: be more paranoid about available space when creating variables >>>> >>>> This prevents a bricking issue for some Samsung devices but causes >>>> regression on many other machines. >>>> >>>> https://bugzilla.kernel.org/show_bug.cgi?id=55471 >>>> https://bugzilla.redhat.com/show_bug.cgi?id=947142 >>>> http://article.gmane.org/gmane.linux.kernel.efi/1078 >>>> http://article.gmane.org/gmane.linux.kernel.stable/47150 >>>> >>>> This patchset will fix it again: >>>> >>>> http://thread.gmane.org/gmane.linux.kernel.efi/1081 >>> >>> Thanks for the pointer. I note that in that thread you yourself imply >>> there are still issues after applying them? Was that accurate, is there >>> yet further patches needed? >> >> I just find that issue. Didn't see that when writing the above. >> >> Earlier I was testing on a different machine and the result was >> good. I guess the patch still needs some more testing. > > Thanks Lingzhu. > > So, I guess you would recommend me to drop the whole series until we > have this patchset accepted, tested and back-ported for 3.5, correct? > > (I tried to isolate the one you pointed out, but I'm afraid there are > too many dependencies between them to drop a single patch.) Unfortunately yes. The whole series are mostly solving pstore bugs and pstore trashing firmware. If you want to prevent more bricking from happening asap, a temporary choice is to allow disabling efi pstore altogether with these: ed9dc8ce7a1c8115dba9483a9b51df8b63a2e0ef efivars: Allow disabling use as a pstore backend ec0971ba5372a4dfa753f232449d23a8fd98490e efivars: Add module parameter to disable use as a pstore backend ca0ba26fbbd2d81c43085df49ce0abfe34535a90 efivars: Fix check for CONFIG_EFI_VARS_PSTORE_DEFAULT_DISABLE -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/