Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965570Ab3DREFF (ORCPT ); Thu, 18 Apr 2013 00:05:05 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:24768 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S965149Ab3DREFD (ORCPT ); Thu, 18 Apr 2013 00:05:03 -0400 X-IronPort-AV: E=Sophos;i="4.87,498,1363104000"; d="scan'208";a="7083730" Message-ID: <516F71F3.7090805@cn.fujitsu.com> Date: Thu, 18 Apr 2013 12:09:23 +0800 From: Wang Shilong User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: yongjun_wei@trendmicro.com.cn, Wei Yongjun CC: linux-kernel@vger.kernel.org Subject: Re:[PATCH -next] ALSA: hda - fix error return code in patch_alc662() X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/04/18 12:03:35, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/04/18 12:03:36, Serialize complete at 2013/04/18 12:03:36 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 724 Lines: 26 Hello Wei, +++ b/sound/pci/hda/patch_realtek.c @@ -3787,7 +3787,8 @@ static int patch_alc662(struct hda_codec *codec) if ((alc_get_coef0(codec) & (1 << 14)) && codec->bus->pci->subsystem_vendor == 0x1025 && spec->cdefine.platform_type == 1) { - if (alc_codec_rename(codec, "ALC272X") < 0) I don't think we should fix this problem. And your changelog is wrong! Thanks, Wang + err = alc_codec_rename(codec, "ALC272X"); + if (err < 0) goto error; } -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/