Message-ID: <516F7312.3050002@cn.fujitsu.com>
Date: Thu, 18 Apr 2013 12:14:10 +0800
From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
CC: yongjun_wei@trendmicro.com.cn, Wei Yongjun <weiyj.lk@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ALSA: hda - fix error return code in patch_alc662()
References: <516F71F3.7090805@cn.fujitsu.com>
In-Reply-To: <516F71F3.7090805@cn.fujitsu.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 810
Lines: 34

Sorry, i miss something..

Thanks,
wang

> Hello Wei,
> 
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -3787,7 +3787,8 @@ static int patch_alc662(struct hda_codec *codec)
>  	if ((alc_get_coef0(codec) & (1 << 14)) &&
>  	    codec->bus->pci->subsystem_vendor == 0x1025 &&
>  	    spec->cdefine.platform_type == 1) {
> -		if (alc_codec_rename(codec, "ALC272X") < 0)
> 
> I don't think we should fix this problem. And your changelog is wrong!
> 
> Thanks,
> Wang
> +		err = alc_codec_rename(codec, "ALC272X");
> +		if (err < 0)
>  			goto error;
>  	}
>  
> 
> --
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/