Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754137Ab3DRETT (ORCPT ); Thu, 18 Apr 2013 00:19:19 -0400 Received: from mail.active-venture.com ([67.228.131.205]:59690 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753903Ab3DRETS (ORCPT ); Thu, 18 Apr 2013 00:19:18 -0400 X-Originating-IP: 108.223.40.66 Date: Wed, 17 Apr 2013 21:19:40 -0700 From: Guenter Roeck To: Thomas Gleixner Cc: Kevin Strasser , linux-kernel@vger.kernel.org, Michael Brunner , Samuel Ortiz , Wolfram Sang , Ben Dooks , linux-i2c@vger.kernel.org, Grant Likely , Linus Walleij , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Darren Hart , Michael Brunner , Greg Kroah-Hartman , Joe Perches Subject: Re: [PATCH 1/4] mfd: Kontron PLD mfd driver Message-ID: <20130418041940.GB7535@roeck-us.net> References: <1365441321-21952-1-git-send-email-kevin.strasser@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 24 On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: [ ... ] > > > + return kempld_read8(pld, index) | kempld_read8(pld, index+1) << 8; > > index + 1) > Please > Wondering .... why does checkpatch not report those ? I just reviewed another driver with the same kind of problem, and checkpatch is just as silent. There seems to be a whole class of expressions where it does not complain about missing spaces. Joe, any idea ? Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/