Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966492Ab3DRHz4 (ORCPT ); Thu, 18 Apr 2013 03:55:56 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34933 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965286Ab3DRHzz (ORCPT ); Thu, 18 Apr 2013 03:55:55 -0400 Date: Thu, 18 Apr 2013 09:55:50 +0200 Message-ID: From: Takashi Iwai To: Wei Yongjun Cc: perex@perex.cz, david.henningsson@canonical.com, kailang@realtek.com, yongjun_wei@trendmicro.com.cn, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] ALSA: hda - fix error return code in patch_alc662() In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 39 At Thu, 18 Apr 2013 11:12:59 +0800, Wei Yongjun wrote: > > From: Wei Yongjun > > Fix to return a negative error code from the error handling > case instead of 0, as returned elsewhere in this function. > > Signed-off-by: Wei Yongjun Thanks, applied. Takashi > --- > sound/pci/hda/patch_realtek.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index f15c36b..a3965b0 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -3787,7 +3787,8 @@ static int patch_alc662(struct hda_codec *codec) > if ((alc_get_coef0(codec) & (1 << 14)) && > codec->bus->pci->subsystem_vendor == 0x1025 && > spec->cdefine.platform_type == 1) { > - if (alc_codec_rename(codec, "ALC272X") < 0) > + err = alc_codec_rename(codec, "ALC272X"); > + if (err < 0) > goto error; > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/