Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966557Ab3DRIja (ORCPT ); Thu, 18 Apr 2013 04:39:30 -0400 Received: from mail-we0-f172.google.com ([74.125.82.172]:63370 "EHLO mail-we0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966349Ab3DRIj2 (ORCPT ); Thu, 18 Apr 2013 04:39:28 -0400 Date: Thu, 18 Apr 2013 09:39:22 +0100 From: Lee Jones To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, linus.walleij@stericsson.com, Greg Kroah-Hartman , Jiri Slaby Subject: Re: [PATCH v2] serial: pl011: Add Device Tree support to request DMA channels Message-ID: <20130418083922.GC3137@gmail.com> References: <1366272857-14038-1-git-send-email-lee.jones@linaro.org> <20130418081811.GF14496@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130418081811.GF14496@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1375 Lines: 33 On Thu, 18 Apr 2013, Russell King - ARM Linux wrote: > On Thu, Apr 18, 2013 at 09:14:16AM +0100, Lee Jones wrote: > > @@ -269,7 +270,10 @@ static void pl011_dma_probe_initcall(struct uart_amba_port *uap) > > dma_cap_zero(mask); > > dma_cap_set(DMA_SLAVE, mask); > > > > - chan = dma_request_channel(mask, plat->dma_filter, plat->dma_tx_param); > > + chan = dma_request_slave_channel_compat(mask, > > + (plat) ? plat->dma_filter : NULL, > > + (plat) ? plat->dma_tx_param : NULL, > > + uap->port.dev, "tx"); > > if (!chan) { > > dev_err(uap->port.dev, "no TX DMA channel!\n"); > > return; > > This suffers the same problem with your MMCI patch. If you're using DT and > don't provide the DMA information, you get errors printed. That's not on > for an optional driver feature, especially when that feature causes > functional difficulties on various platforms and so is _purposely_ omitted. How does that differ from using pdata and not passing DMA information? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/