From: Arnd Bergmann <arnd@arndb.de>
To: Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 07/32] ARM: ux500: Supply address location names for the DMA40 DMA controller
Date: Thu, 18 Apr 2013 12:48:36 +0200
User-Agent: KMail/1.12.2 (Linux/3.8.0-18-generic; KDE/4.3.2; x86_64; ; )
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linus.walleij@stericsson.com
References: <1366279934-30761-1-git-send-email-lee.jones@linaro.org> <1366279934-30761-8-git-send-email-lee.jones@linaro.org>
In-Reply-To: <1366279934-30761-8-git-send-email-lee.jones@linaro.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201304181248.36597.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 910
Lines: 22

On Thursday 18 April 2013, Lee Jones wrote:
> The DMA40 controller uses two sets of base addresses. In order to have
> them automatically setup as resources by the Open Format framework we
> have to set names for them. The names have to be the same as the ones
> used to fetch them back out of the resource structure.
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Typo: s/Open Format/Open Firmware/

To be more specific, just write of_platform framework. Note that we
still get resources without passing the names, they are just not
named in that case and have to be retrieved by index.

You should also document the strings in the binding document.

	ARnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/