Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936391Ab3DRQmW (ORCPT ); Thu, 18 Apr 2013 12:42:22 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:39970 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S936266Ab3DRQmS (ORCPT ); Thu, 18 Apr 2013 12:42:18 -0400 Message-ID: <1366303337.2119.22.camel@joe-AO722> Subject: Re: [PATCH 1/4] mfd: Kontron PLD mfd driver From: Joe Perches To: Guenter Roeck Cc: Thomas Gleixner , Kevin Strasser , linux-kernel@vger.kernel.org, Michael Brunner , Samuel Ortiz , Wolfram Sang , Ben Dooks , linux-i2c@vger.kernel.org, Grant Likely , Linus Walleij , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Darren Hart , Michael Brunner , Greg Kroah-Hartman Date: Thu, 18 Apr 2013 09:42:17 -0700 In-Reply-To: <20130418133555.GA2767@roeck-us.net> References: <1365441321-21952-1-git-send-email-kevin.strasser@linux.intel.com> <20130418041940.GB7535@roeck-us.net> <1366260053.28609.66.camel@joe-AO722> <20130418133555.GA2767@roeck-us.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.2-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1357 Lines: 34 On Thu, 2013-04-18 at 06:35 -0700, Guenter Roeck wrote: > On Wed, Apr 17, 2013 at 09:40:53PM -0700, Joe Perches wrote: > > On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: > > > On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: > > > > > + return kempld_read8(pld, index) | kempld_read8(pld, index+1) << 8; > > > > index + 1) > > > > Please > > > Wondering .... why does checkpatch not report those ? > > > > because checkpatch doesn't care about spacing around > > arithmetic as long as it's consistent. > > > > Documentation/CodingStyle doesn't say anything about > > it either. > > > Hi Joe, > > "Use one space around (on each side of) most binary and ternary operators" > > doesn't apply, then ? When does it apply ? I always thought it would apply > to cases such as the above. There's a _lot_ of code that doesn't follow the "single space around binary operators" style, it's contentious, and was determined when Andy did the original checkpatch implementation to not be a valuable addition or worth the complaint pain. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/