Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967711Ab3DRQmb (ORCPT ); Thu, 18 Apr 2013 12:42:31 -0400 Received: from www.sr71.net ([198.145.64.142]:52069 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936352Ab3DRQmV (ORCPT ); Thu, 18 Apr 2013 12:42:21 -0400 Message-ID: <51702267.3040205@sr71.net> Date: Thu, 18 Apr 2013 09:42:15 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: "Kirill A. Shutemov" CC: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3, RFC 31/34] thp: initial implementation of do_huge_linear_fault() References: <1365163198-29726-1-git-send-email-kirill.shutemov@linux.intel.com> <1365163198-29726-32-git-send-email-kirill.shutemov@linux.intel.com> <51631206.3060605@sr71.net> <20130417143842.1A76CE0085@blue.fi.intel.com> <516F1D3C.1060804@sr71.net> <20130418160920.4A00DE0085@blue.fi.intel.com> <51701D5E.80802@sr71.net> <20130418163836.B73B2E0085@blue.fi.intel.com> In-Reply-To: <20130418163836.B73B2E0085@blue.fi.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1111 Lines: 32 On 04/18/2013 09:38 AM, Kirill A. Shutemov wrote: > Dave Hansen wrote: >> On 04/18/2013 09:09 AM, Kirill A. Shutemov wrote: >>> Dave Hansen wrote: >>>> On 04/17/2013 07:38 AM, Kirill A. Shutemov wrote: >>>> Are you still sure you can't do _any_ better than a verbatim copy of 129 >>>> lines? >>> >>> It seems I was too lazy. Shame on me. :( >>> Here's consolidated version. Only build tested. Does it look better? >> >> Yeah, it's definitely a step in the right direction. There rae >> definitely some bugs in there like: >> >> + unsigned long haddr = address & PAGE_MASK; > > It's not bug. It's bad name for the variable. > See, first 'if (try_huge_pages)'. I update it there for huge page case. > > addr_aligned better? That's a criminally bad name. :) addr_aligned is better, and also please initialize the two cases together. It's mean to separate them. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/