Message-ID: <51702D5E.6060304@nvidia.com>
Date: Thu, 18 Apr 2013 22:59:02 +0530
From: Laxman Dewangan <ldewangan@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2
MIME-Version: 1.0
To: Axel Lin <axel.lin@ingics.com>
CC: Mark Brown <broonie@opensource.wolfsonmicro.com>,
        Graeme Gregory <gg@slimlogic.co.uk>,
        Liam Girdwood <lgirdwood@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFT] regulator: palmas: Fix min_uV for LDO8 tracking mode
References: <1366304032.27953.1.camel@phoenix>
In-Reply-To: <1366304032.27953.1.camel@phoenix>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1156
Lines: 30

On Thursday 18 April 2013 10:23 PM, Axel Lin wrote:
> When SMPS45 is set to off and LDO8 tracking is enabled, the output voltage can
> be set from 0.45 to 1.65 V. Thus set min_uV to be 450000.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi Laxman,
> My understanding is based on your comment in the code.
>          /*
>           * When SMPS45 is set to off and LDO8 tracking is enabled, the LDO8
>           * output is defined by the LDO8_VOLTAGE.VSEL register divided by two,
>           * and can be set from 0.45 to 1.65 V.
>           */
>
> Can you confirm if this patch is correct or not?

Yes, this is correct.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>


Unfortunately the PMIC device which we have is having bug for which we 
are disabling tracking before going to suspend and enabling again in 
resume and hence it is not
caught. I will pull this change to my downstream also.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/