Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753776Ab3DRSRP (ORCPT ); Thu, 18 Apr 2013 14:17:15 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:58227 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752222Ab3DRSRN (ORCPT ); Thu, 18 Apr 2013 14:17:13 -0400 Date: Thu, 18 Apr 2013 11:17:09 -0700 From: Tejun Heo To: Masami Hiramatsu Cc: Ingo Molnar , Linus Torvalds , linux-kernel@vger.kernel.org, "David S. Miller" , Ananth N Mavinakayanahalli , yrl.pp-manager.tt@hitachi.com Subject: Re: [PATCH -tip ] [BUGFIX] kprobes: Fix a double lock bug of kprobe_mutex Message-ID: <20130418181709.GE9897@mtj.dyndns.org> References: <20130418093318.13070.29847.stgit@mhiramat-M0-7522> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130418093318.13070.29847.stgit@mhiramat-M0-7522> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 30 On Thu, Apr 18, 2013 at 06:33:18PM +0900, Masami Hiramatsu wrote: > Fix a double locking bug caused when debug.kprobe-optimization=0. > While the proc_kprobes_optimization_handler locks kprobe_mutex, > wait_for_kprobe_optimizer locks it again and that causes a double lock. > To fix the bug, this introduces different mutex for protecting > sysctl parameter and locks it in proc_kprobes_optimization_handler. > Of course, since we need to lock kprobe_mutex when touching kprobes > resources, that is done in *optimize_all_kprobes(). > > This bug was from ad72b3bea744b4db01c89af0f86f3e8920d354df > > Signed-off-by: Masami Hiramatsu > Cc: Ingo Molnar > Cc: Tejun Heo > Cc: Ananth N Mavinakayanahalli > Cc: "David S. Miller" Oops, Acked-by: Tejun Heo Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/