Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030828Ab3DSOu4 (ORCPT ); Fri, 19 Apr 2013 10:50:56 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:38914 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030593Ab3DSOuz (ORCPT ); Fri, 19 Apr 2013 10:50:55 -0400 Message-ID: <51715988.9060606@cogentembedded.com> Date: Fri, 19 Apr 2013 18:49:44 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Nicolas Ferre CC: linux-arm-kernel@lists.infradead.org, Jean-Christophe PLAGNIOL-VILLARD , Ludovic Desroches , linux-kernel@vger.kernel.org, tanzilli@acmesystems.it, dgilbert@interlog.com, robertcnelson@gmail.com Subject: Re: [PATCH 1/5] ARM: at91: at91sam9x5 RTC is not compatible with at91rm9200 one References: <864f10566b35864d469f6ff2913b9afaa0c69350.1366289869.git.nicolas.ferre@atmel.com> <51714C74.2030907@cogentembedded.com> <51714F47.5040006@atmel.com> In-Reply-To: <51714F47.5040006@atmel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1692 Lines: 47 On 19-04-2013 18:05, Nicolas Ferre wrote: >>> Due to a bug with RTC IMR, we cannot consider at91sam9x5 RTC compatible >>> with the previous one. Modify DT compatibility string, even if the driver >>> is not yet modified to take it into account. >>> Signed-off-by: Nicolas Ferre >>> --- >>> arch/arm/boot/dts/at91sam9x5.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi >>> b/arch/arm/boot/dts/at91sam9x5.dtsi >>> index a3d4464..58747f3 100644 >>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi >>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi >>> @@ -564,7 +564,7 @@ >>> }; >>> >>> rtc@fffffeb0 { >>> - compatible = "atmel,at91rm9200-rtc"; >>> + compatible = "atmel,at91sam9x5-rtc"; >> Do not use wildcards in the "compatible" prop values (I guess 'x' is >> a wildcard). > Well, it is for naming a series of hardware, not for giving a generic > name that could cover different hardware. > In the sense of Atmel it is our way to call the at91sam9x5 series of > SoC: you will see that the code that covers these SoCs is always named > like this. > In fact, the hardware contained in these SoC cannot be different from > one flavor of the family to the other. Nevertheless, the wildcards shouldn't be used. Use the name of e.g. the first member of the family. > Best regards, WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/