Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752603Ab3DSRhz (ORCPT ); Fri, 19 Apr 2013 13:37:55 -0400 Received: from mail-bk0-f43.google.com ([209.85.214.43]:52099 "EHLO mail-bk0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812Ab3DSRhx (ORCPT ); Fri, 19 Apr 2013 13:37:53 -0400 Message-ID: <517180F9.8060601@gmail.com> Date: Fri, 19 Apr 2013 19:38:01 +0200 From: Daniel Mack User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 MIME-Version: 1.0 To: Michal Bachraty CC: perex@perex.cz, tiwai@suse.de, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, marek.belisko@streamunlimited.com, broonie@opensource.wolfsonmicro.com, lgirdwood@gmail.com Subject: Re: [alsa-devel] [PATCH 2/2] ALSA: ASoc: davinci-mcasp: Add Support BCLK-to-LRCLK ratio for TDM modes References: <1366378124-14368-1-git-send-email-michal.bachraty@streamunlimited.com> In-Reply-To: <1366378124-14368-1-git-send-email-michal.bachraty@streamunlimited.com> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2249 Lines: 54 On 19.04.2013 15:28, Michal Bachraty wrote: > For TDM mode, BCLK-to-LCLK ratio is computed as (tdm_slots) x (word_length). > I2S mode is only subset of TDM mode with specific tdm_slots = 2 channels. > Also bclk_lrclk_ratio can be greater than 255, therefore u16 need to be used. > > Signed-off-by: Michal Bachraty Acked-by: Daniel Mack > --- > sound/soc/davinci/davinci-mcasp.c | 7 ++++--- > sound/soc/davinci/davinci-mcasp.h | 2 +- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c > index 63633e9..d54e0d9 100644 > --- a/sound/soc/davinci/davinci-mcasp.c > +++ b/sound/soc/davinci/davinci-mcasp.c > @@ -636,11 +636,12 @@ static int davinci_config_channel_size(struct davinci_audio_dev *dev, > * callback, take it into account here. That allows us to for example > * send 32 bits per channel to the codec, while only 16 of them carry > * audio payload. > - * The clock ratio is given for a full period of data (both left and > - * right channels), so it has to be divided by 2. > + * The clock ratio is given for a full period of data (for I2S format > + * both left and right channels), so it has to be divided by number of > + * tdm-slots (for I2S - divided by 2). > */ > if (dev->bclk_lrclk_ratio) > - word_length = dev->bclk_lrclk_ratio / 2; > + word_length = dev->bclk_lrclk_ratio / dev->tdm_slots; > > /* mapping of the XSSZ bit-field as described in the datasheet */ > fmt = (word_length >> 1) - 1; > diff --git a/sound/soc/davinci/davinci-mcasp.h b/sound/soc/davinci/davinci-mcasp.h > index 0edd3b5..a9ac0c1 100644 > --- a/sound/soc/davinci/davinci-mcasp.h > +++ b/sound/soc/davinci/davinci-mcasp.h > @@ -38,7 +38,7 @@ struct davinci_audio_dev { > u8 num_serializer; > u8 *serial_dir; > u8 version; > - u8 bclk_lrclk_ratio; > + u16 bclk_lrclk_ratio; > > /* McASP FIFO related */ > u8 txnumevt; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/