From: Arnd Bergmann <arnd@arndb.de>
To: "Lars-Peter Clausen" <lars@metafoo.de>
Subject: Re: [PATCH 2/2] dma:of: Use a mutex to protect the of_dma_list
Date: Sat, 20 Apr 2013 12:38:08 +0200
User-Agent: KMail/1.12.2 (Linux/3.8.0-18-generic; KDE/4.3.2; x86_64; ; )
Cc: Jon Hunter <jon-hunter@ti.com>, Vinod Koul <vinod.koul@intel.com>,
        linux-kernel@vger.kernel.org
References: <1366364534-3298-1-git-send-email-lars@metafoo.de> <5171C8F6.6010702@ti.com> <51724393.1060608@metafoo.de>
In-Reply-To: <51724393.1060608@metafoo.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201304201238.08908.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 782
Lines: 19

On Saturday 20 April 2013, Lars-Peter Clausen wrote:
> On 04/20/2013 12:45 AM, Jon Hunter wrote:
> > I think that there is a problem here. For controllers using the
> > of_dma_simple_xlate(), this will call dma_request_channel() which also
> > uses a mutex.
> 
> That would only be a problem if it'd use the same mutex. Holding two mutexes at
> the same time is not a problem per se.
> 

I guess Jon originlly tried it with a spinlock as the outer lock, which indeed
does not work, but the new version does not have this problem.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/