Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932386Ab3DTPxQ (ORCPT ); Sat, 20 Apr 2013 11:53:16 -0400 Received: from terminus.zytor.com ([198.137.202.10]:33974 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932191Ab3DTPxP (ORCPT ); Sat, 20 Apr 2013 11:53:15 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <51725ED4.8020001@nexus-software.ie> References: <1366392183-4149-1-git-send-email-bryan.odonoghue.lkml@nexus-software.ie> <20130419191128.GA21991@pd.tnic> <5171AA86.604@nexus-software.ie> <20130419205515.GA3075@pd.tnic> <20130419212514.GC3075@pd.tnic> <5171BAD6.4040003@nexus-software.ie> <5171CF86.30708@zytor.com> <51725ED4.8020001@nexus-software.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] x86: Add check for P5 to microcode_intel_early From: "H. Peter Anvin" Date: Sat, 20 Apr 2013 08:52:55 -0700 To: "Bryan O'Donoghue" CC: Borislav Petkov , linux-kernel@vger.kernel.org, x86@kernel.org, fenghua.yu@intel.com Message-ID: <2cca7cab-e8b2-41fc-b757-22f37b78f99b@email.android.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1647 Lines: 50 I committed my own patch yesterday; at this point it would be most helpful if you could test it out to make sure it works as it should... Bryan O'Donoghue wrote: >On 20/04/13 00:13, H. Peter Anvin wrote: >> On 04/19/2013 02:44 PM, Bryan O'Donoghue wrote: >>> On 19/04/13 22:25, Borislav Petkov wrote: >>>> On Fri, Apr 19, 2013 at 10:55:15PM +0200, Borislav Petkov wrote: >>>>> Just filter out P5 and earlier. The code already does that for >CPUs >>>>> which don't have CPUID. >>>> >>>> Actually, an alternative - more practical albeit not very accurate >>> >>> More practical ? Hmm - the MSRs don't exist for< P5 >>> >>>> solution would be to check for which families Intel delivers >microcode >>>> and do the cut off there with a comment as to why you do it like >>>> that.void >>> >>> You mean return !intel so this function will never be called. >>> >>> __init load_ucode_bsp(void) >>> { >>> int vendor = x86_vendor(); >>> >>> if (vendor == X86_VENDOR_INTEL) >>> load_ucode_intel_bsp(); >>> } >>> >>> Ah yes. That would work and be less code. >>> >>> We should do it that way. >> >> Do you think you can have a patch for me in the next few hours? > >Sure. > >I'm in Ireland (sleeping @ 00:15 on a Friday night sadly). > >Give me ~ 40 minutes -- Sent from my mobile phone. Please excuse brevity and lack of formatting. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/