Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932422Ab3DTQC2 (ORCPT ); Sat, 20 Apr 2013 12:02:28 -0400 Received: from mail-ie0-f178.google.com ([209.85.223.178]:46742 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932253Ab3DTQC1 (ORCPT ); Sat, 20 Apr 2013 12:02:27 -0400 MIME-Version: 1.0 In-Reply-To: <20130419181155.GA13811@mtj.dyndns.org> References: <1365957716-7631-1-git-send-email-laijs@cn.fujitsu.com> <20130419181155.GA13811@mtj.dyndns.org> Date: Sun, 21 Apr 2013 00:02:26 +0800 Message-ID: Subject: Re: [PATCH 0/8] workqueue: advance concurrency management From: Lai Jiangshan To: Tejun Heo Cc: LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1304 Lines: 39 On Sat, Apr 20, 2013 at 2:11 AM, Tejun Heo wrote: > Hey, > > On Fri, Apr 19, 2013 at 06:10:57AM +0800, Lai Jiangshan wrote: >> Ping. > > Sorry, I've been at collab summit / lsf. Plus, it's a bit too late > for for-3.10 anyway. Anyways, after glancing over it, here are my > preliminary thoughts. The first one looks good but I'm not sure about > dropping nr_running adjustment. The only real benefit coming from > that is dropping a sched callback and if there's any performance / > overhead impact, I'm afraid it's gonna be negative. There are actual > benefits in using as few tasks as possible - waking_up() callback doesn't win too much in this. > the cache footprint gets smaller, cache footprint also be reduced in different way in the patchset. and memory atomic operations are reduced. > so unless there's a clear indication that the suggested Only simple. and remove the optimization from rare cases. > behavior is better in some way, I'm not sure what we're buying with > the proposed changes. > > Thanks. > > -- > tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/