Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754153Ab3DTTtT (ORCPT ); Sat, 20 Apr 2013 15:49:19 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:34584 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753020Ab3DTTtS (ORCPT ); Sat, 20 Apr 2013 15:49:18 -0400 Date: Sat, 20 Apr 2013 15:49:15 -0400 (EDT) Message-Id: <20130420.154915.406609194782936166.davem@davemloft.net> To: jovi.zhangwei@huawei.com Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/8] spare/sysrq: fix inconstistent help message of sysrq key From: David Miller In-Reply-To: <5172468F.7070909@huawei.com> References: <51385730.7020606@huawei.com> <20130307.162724.2043364205781900432.davem@davemloft.net> <5172468F.7070909@huawei.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (shards.monkeyblade.net [0.0.0.0]); Sat, 20 Apr 2013 12:49:17 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 35 From: "zhangwei(Jovi)" Date: Sat, 20 Apr 2013 15:41:03 +0800 > On 2013/3/8 5:27, David Miller wrote: >> From: "zhangwei(Jovi)" >> Date: Thu, 7 Mar 2013 17:00:32 +0800 >> >>> Currently help message of /proc/sysrq-trigger highlight its >>> upper-case characters, like below: >>> >>> SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E) >>> memory-full-oom-kill(F) kill-all-tasks(I) ... >>> >>> this would confuse user trigger sysrq by upper-case character, which is >>> inconsistent with the real lower-case character registed key. >>> >>> This inconsistent help message will also lead more confused when >>> 26 upper-case letters put into use in future. >>> >>> This patch fix spare sysrq key: "global-regs(y)" >>> >>> Signed-off-by: zhangwei(Jovi) >> >> Acked-by: David S. Miller >> > David, this patch is already got your ack, > so would you please pick up this patch into your tree for next 3.10? Sparc patches should be sent to sparclinux@vger.kernel.org so that they are properly queued up and tracked in patchwork. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/