Date: Sun, 21 Apr 2013 12:35:08 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>, avi.kivity@gmail.com,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v3 00/15] KVM: MMU: fast zap all shadow pages
Message-ID: <20130421153508.GA28842@amt.cnet>
References: <1366093973-2617-1-git-send-email-xiaoguangrong@linux.vnet.ibm.com>
 <20130421130346.GE8997@redhat.com>
 <20130421152751.GB28437@amt.cnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130421152751.GB28437@amt.cnet>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1538
Lines: 41

On Sun, Apr 21, 2013 at 12:27:51PM -0300, Marcelo Tosatti wrote:
> On Sun, Apr 21, 2013 at 04:03:46PM +0300, Gleb Natapov wrote:
> > On Tue, Apr 16, 2013 at 02:32:38PM +0800, Xiao Guangrong wrote:
> > > This patchset is based on my previous two patchset:
> > > [PATCH 0/2] KVM: x86: avoid potential soft lockup and unneeded mmu reload
> > > (https://lkml.org/lkml/2013/4/1/2)
> > > 
> > > [PATCH v2 0/6] KVM: MMU: fast invalid all mmio sptes
> > > (https://lkml.org/lkml/2013/4/1/134)
> > > 
> > > Changlog:
> > > V3:
> > >   completely redesign the algorithm, please see below.
> > > 
> > This looks pretty complicated. Is it still needed in order to avoid soft
> > lockups after "avoid potential soft lockup and unneeded mmu reload" patch?
> 
> Do not want kvm_set_memory (cases: DELETE/MOVE/CREATES) to be
> suspectible to:
> 
> vcpu 1    		|	kvm_set_memory
> create shadow page 		
> 				nuke shadow page
> create shadow page
> 				nuke shadow page
> 
> Which is guest triggerable behavior with spinlock preemption algorithm.

Not only guest triggerable as in the sense of a malicious guest, 
but condition above can be induced by host workload with non-malicious
guest system.

Also kvm_set_memory being relatively fast with huge memory guests
is nice (which is what Xiaos idea allows).


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/