Message-id: <1366598966.31792.1.camel@kjgkr>
Subject: Re: [PATCH 2/2] f2fs: add REQ_META about metadata requests for submit
 bio
From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Reply-to: jaegeuk.kim@samsung.com
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, Namjae Jeon <namjae.jeon@samsung.com>,
        Amit Sahrawat <a.sahrawat@samsung.com>
Date: Mon, 22 Apr 2013 11:49:26 +0900
In-reply-to: <1366388860-18735-1-git-send-email-linkinjeon@gmail.com>
References: <1366388860-18735-1-git-send-email-linkinjeon@gmail.com>
Organization: samsung
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="=-g20TwTWUuRq3HjrG/5MM"
MIME-version: 1.0
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2627
Lines: 75


--=-g20TwTWUuRq3HjrG/5MM
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2013-04-20 (=ED=86=A0), 01:27 +0900, Namjae Jeon:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>=20
> Adding REQ_META for all the metadata requests can help in improving the
> FS performance, if the underlying device supports TAGGING.
> So, when considering the submit_bio path for all the f2fs requests. We ca=
n
> add REQ_META for all the META requests.
> As a precursor to this change we considered the commit
> 4265900e0be653f5b78baf2816857ef57cf1332f 'mmc: MMC-4.5 Data Tag Support'
>=20
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> ---
>  fs/f2fs/segment.c |    3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 1193a26..a2e5de7 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -689,6 +689,9 @@ static void do_submit_bio(struct f2fs_sb_info *sbi,
>  	if (type >=3D META_FLUSH)
>  		rw =3D WRITE_FLUSH_FUA;
> =20
> +	if (type =3D=3D META)

Should be if (btype =3D=3D META).
Thanks,

> +		rw |=3D REQ_META;
> +
>  	if (sbi->bio[btype]) {
>  		struct bio_private *p =3D sbi->bio[btype]->bi_private;
>  		trace_f2fs_do_submit_bio(sbi->sb, btype, sync,

--=20
Jaegeuk Kim
Samsung

--=-g20TwTWUuRq3HjrG/5MM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAABAgAGBQJRdKU2AAoJEEAUqH6CSFDS1+EP/1eIx9sHNoWdPNXKM9X8kG1E
/0jKevODrDQFrr3uJuzpXdm7OrpxsUZgruvSuWifpzpw57AkMpOTfv7VYWClkOR/
9yzPP7dBKtg115tVZb6DathpMSZys8xawBvyCCohyiAVI0Gke/oBKTLUC/T4pas+
kw4g5mvGYnqx5gj/Nn6HUGQV0LYOCrHzqwbng91sAb3nhUETqbCg9HfjtkVbijBs
itBpBP47hTvdzMHdZjW7m/n6RRFqlF9jNmFbjTpDgGttKubHQ8VN6WBLRWd1WgmE
bwUb4nkFZMSbZff74AoI/49ZxXhkCS4/5QfT/idSpdDNoTlHS6Er+oE1cnk2YVR6
WuEEFBZJUGGJ0lLyAta6lC52TRYo8f5M1ymKvwV3Gc4PyWn14Fmm+EqZCMbQH0XO
UKxEoCh5Qf/ACOUgPaeh0eW+BLk5hqVXEC9Oexpda7LVTbAidwB3rx+tIXAbJGAl
sewojqrOTXYAskgtXMMcW0ZkaUUu/ca1ItO6sgCqLI1R29TmDVGU14iAMQvbH4Wj
C5vUNL6Qjid1+ucqsIu0IJbhJ1mIifsz/eyapIcy8AbqN/SDXU1JQ38rb22KxQMd
sztrBmQiepfDizoX0/CIkcx3Iqeg7wG/qZbxYRrrSfwFMYaeUxk3S9iz7qIUE48H
rvVrB9uRxNY1vBSDOW7M
=d+60
-----END PGP SIGNATURE-----

--=-g20TwTWUuRq3HjrG/5MM--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/