Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754785Ab3DVGaT (ORCPT ); Mon, 22 Apr 2013 02:30:19 -0400 Received: from mail-we0-f177.google.com ([74.125.82.177]:38367 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754051Ab3DVGaR convert rfc822-to-8bit (ORCPT ); Mon, 22 Apr 2013 02:30:17 -0400 MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: <1366611749.27110.6.camel@liguang.fnst.cn.fujitsu.com> References: <1366609643-17628-1-git-send-email-lig.fnst@cn.fujitsu.com> <1366611749.27110.6.camel@liguang.fnst.cn.fujitsu.com> Date: Mon, 22 Apr 2013 08:30:16 +0200 Message-ID: Subject: Re: [PATCH 1/2] smp: use '|=' for csd_lock From: Sedat Dilek To: li guang Cc: tglx@linutronix.de, peterz@infradead.org, akpm@linux-foundation.org, shli@fusionio.com, srivatsa.bhat@linux.vnet.ibm.com, suresh.b.siddha@intel.com, fweisbec@gmail.com, paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1974 Lines: 72 On Mon, Apr 22, 2013 at 8:22 AM, li guang wrote: > 在 2013-04-22一的 08:18 +0200，Sedat Dilek写道： >> On Mon, Apr 22, 2013 at 7:47 AM, liguang wrote: >> > originally, 'data->flags = CSD_FLAG_LOCK', >> > and we use 'data->flags &= ~CSD_FLAG_LOCK' >> > for csd_unlock, they are not symmetrix operations >> > so use '|=' instead of '='. >> > though, now data->flags only hold CSD_FLAG_LOCK, >> > it's not so meaningful to use '|=' to set 1 bit, >> > and '&= ~' to clear 1 bit. >> > >> >> Hi, >> >> what's the reason I got CCed on this two patches? The ipc-sem-next >> issue I reported? > > sorry, > just use the result of scripts/get_maintainer.pl > Hmm, really this script memyselfandI as a result? >> >> Against what tree are those patches? >> They are not compatible with Linux-Next (next-20130419). > > main > Andrew renamed data/csd,so it's only 1/2 needing a refresh. Testing... Regards, - Sedat - >> >> Thanks. >> >> Regards, >> - Sedat - >> >> [1] http://marc.info/?t=136631457900005&r=1&w=2 >> >> > Signed-off-by: liguang >> > --- >> > kernel/smp.c | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/kernel/smp.c b/kernel/smp.c >> > index 1818dc0..2d5deb4 100644 >> > --- a/kernel/smp.c >> > +++ b/kernel/smp.c >> > @@ -109,7 +109,7 @@ static void csd_lock_wait(struct call_single_data *data) >> > static void csd_lock(struct call_single_data *data) >> > { >> > csd_lock_wait(data); >> > - data->flags = CSD_FLAG_LOCK; >> > + data->flags |= CSD_FLAG_LOCK; >> > >> > /* >> > * prevent CPU from reordering the above assignment >> > -- >> > 1.7.2.5 >> > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/