Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755077Ab3DVJTK (ORCPT ); Mon, 22 Apr 2013 05:19:10 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44807 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013Ab3DVJTI (ORCPT ); Mon, 22 Apr 2013 05:19:08 -0400 Date: Mon, 22 Apr 2013 11:19:07 +0200 Message-ID: From: Takashi Iwai To: Borislav Petkov Cc: paulmck@linux.vnet.ibm.com, x86-ml , lkml Subject: Re: irq 16: nobody cared In-Reply-To: <20130422091310.GA4637@pd.tnic> References: <20130420185330.GA4654@pd.tnic> <20130420235206.GA3509@linux.vnet.ibm.com> <20130421103403.GA4594@pd.tnic> <20130421163002.GB3509@linux.vnet.ibm.com> <20130422091310.GA4637@pd.tnic> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1364 Lines: 41 At Mon, 22 Apr 2013 11:13:10 +0200, Borislav Petkov wrote: > > On Mon, Apr 22, 2013 at 10:32:17AM +0200, Takashi Iwai wrote: > > Hm, if it's really due to a stray irq, just adding the missing > > synchronize_irq() like below would help? > > > > > > Takashi > > > > --- > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > > index 7b213d5..262dbf1 100644 > > --- a/sound/pci/hda/hda_intel.c > > +++ b/sound/pci/hda/hda_intel.c > > @@ -2682,6 +2682,8 @@ static void azx_stop_chip(struct azx *chip) > > /* disable interrupts */ > > azx_int_disable(chip); > > azx_int_clear(chip); > > + if (chip->irq >= 0) > > + synchronize_irq(chip->irq); > > Nope, it doesn't help - I see the same splat. Thanks. Then I have no idea what's missing in the current azx_suspend() and azx_resume() codes. Is the PCI device a HD-audio controller for the built-in analog or a HDMI audio controller coupled with a graphics chip? I wonder why no MSI is used there. MSI should have been used for most of controllers except for cases where blacklisted with PCI SSID or Nvidia / Creative controllers. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/