Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755151Ab3DVKxP (ORCPT ); Mon, 22 Apr 2013 06:53:15 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:36118 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474Ab3DVKxO (ORCPT ); Mon, 22 Apr 2013 06:53:14 -0400 Date: Mon, 22 Apr 2013 11:52:45 +0100 From: Russell King - ARM Linux To: Lee Jones Cc: Vinod Koul , Rabin Vincent , linus.walleij@stericsson.com, arnd@arndb.de, linux-kernel@vger.kernel.org, Per Forlin , Dan Williams , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 21/32] dmaengine: ste_dma40: Also report the number of logical channels Message-ID: <20130422105245.GG14496@n2100.arm.linux.org.uk> References: <1366279934-30761-1-git-send-email-lee.jones@linaro.org> <1366279934-30761-22-git-send-email-lee.jones@linaro.org> <20130422093631.GE24632@intel.com> <20130422101455.GH3432@gmail.com> <20130422094842.GL24632@intel.com> <20130422103715.GK3432@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130422103715.GK3432@gmail.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1658 Lines: 37 On Mon, Apr 22, 2013 at 11:37:15AM +0100, Lee Jones wrote: > On Mon, 22 Apr 2013, Vinod Koul wrote: > > > On Mon, Apr 22, 2013 at 11:14:55AM +0100, Lee Jones wrote: > > > On Mon, 22 Apr 2013, Vinod Koul wrote: > > > > > > > On Thu, Apr 18, 2013 at 11:12:03AM +0100, Lee Jones wrote: > > > > > + dev_info(&pdev->dev, "hardware revision: %d @ 0x%x with " > > > > > + "%d physical channels and %d logical channels\n", > > > > > + rev, res->start, num_phy_chans, num_log_chans); > > > > Splitting log messages across lines is bad idea and sacrifces readablity... also > > > > wasnt splitting logging to multiple lines emit checkpatch warn Yes, but for a different reason... > > > You also get a check-patch error if your lines are over 80 chars. > > No, you get a warn > > You only get a warning for this too: > > WARNING: quoted string split across lines > #33: FILE: drivers/dma/ste_dma40.c:3204: > + dev_info(&pdev->dev, "hardware revision: %d @ 0x%x with " > + "%d physical channels and %d logical channels\n", >From coding style: "However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them." You can argue that you wouldn't grep for the above string - but consider if you grepped for "hardware revision.*channels" to try and find the above message, which would be a reasonable thing to try if you got lots of hits on just "hardware revision". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/