Date: Mon, 22 Apr 2013 10:31:18 -0400
From: =?utf-8?B?SsO2cm4=?= Engel <joern@logfs.org>
To: Joe Perches <joe@perches.com>
Cc: Joern Engel <joern@lazybastard.org>, David Woodhouse <dwmw2@infradead.org>,
        linux-mtd@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: Convert logging messages
Message-ID: <20130422143118.GA12908@logfs.org>
References: <1366394375.3901.36.camel@joe-AO722>
 <20130419165516.GA19480@logfs.org>
 <1366396053.3901.40.camel@joe-AO722>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1366396053.3901.40.camel@joe-AO722>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1184
Lines: 31

On Fri, 19 April 2013 11:27:33 -0700, Joe Perches wrote:
> On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote:
> > On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
> > >  	}
> > >  	list_add(&dev->list, &blkmtd_device_list);
> > > -	INFO("mtd%d: [%s] erase_size = %dKiB [%d]", dev->mtd.index,
> > > -			dev->mtd.name + strlen("block2mtd: "),
> > > -			dev->mtd.erasesize >> 10, dev->mtd.erasesize);
> > > +	pr_info("mtd%d: [%s] erase_size = %dKiB [%d]\n",
> > > +		dev->mtd.index,
> > > +		dev->mtd.name + strlen("block2mtd: "),
> > > +		dev->mtd.erasesize >> 10, dev->mtd.erasesize);
> > 
> > I personally dislike the indent-to-braces style because it causes
> > unnecessary churn in patches like this.
> 
> It comes from an automated emacs conversion.

Then please teach your emacs to be a better tool.  I trust you are
smart enough to do that.

Jörn

--
He who knows that enough is enough will always have enough.
-- Lao Tsu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/