Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754564Ab3DVSTF (ORCPT ); Mon, 22 Apr 2013 14:19:05 -0400 Received: from mail-da0-f46.google.com ([209.85.210.46]:58481 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754496Ab3DVSTE (ORCPT ); Mon, 22 Apr 2013 14:19:04 -0400 Message-ID: <51757F0B.1090104@gmail.com> Date: Mon, 22 Apr 2013 23:48:51 +0530 From: vinayak User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411 Thunderbird/11.0.1 MIME-Version: 1.0 To: Russell King - ARM Linux CC: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rientjes@google.com Subject: Re: [PATCH] mm: add an option to disable bounce References: <1366644180-6140-1-git-send-email-vinayakm.list@gmail.com> <20130422174712.GS14496@n2100.arm.linux.org.uk> In-Reply-To: <20130422174712.GS14496@n2100.arm.linux.org.uk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1681 Lines: 44 On Monday 22 April 2013 11:17 PM, Russell King - ARM Linux wrote: > On Mon, Apr 22, 2013 at 08:53:00PM +0530, vinayakm.list@gmail.com wrote: >> From: Vinayak Menon >> >> There are times when HIGHMEM is enabled, but >> we don't prefer CONFIG_BOUNCE to be enabled. >> CONFIG_BOUNCE can reduce the block device >> throughput, and this is not ideal for machines >> where we don't gain much by enabling it. So >> provide an option to deselect CONFIG_BOUNCE. The >> observation was made while measuring eMMC throughput >> using iozone on an ARM device with 1GB RAM. >> >> Signed-off-by: Vinayak Menon >> --- >> mm/Kconfig | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/mm/Kconfig b/mm/Kconfig >> index 3bea74f..29f9736 100644 >> --- a/mm/Kconfig >> +++ b/mm/Kconfig >> @@ -263,8 +263,14 @@ config ZONE_DMA_FLAG >> default "1" >> >> config BOUNCE >> + bool "Enable bounce buffers" >> def_bool y >> depends on BLOCK && MMU && (ZONE_DMA || HIGHMEM) > > I don't think this is correct. You shouldn't use "bool" with "def_bool". > Sure, add the "bool", but also change "def_bool" to "default". Yes. I will change it to "default" and this looks to be correct even from the definition in kconfig-language.txt. But I see other instances in mm/Kconfig, where bool and def_bool are used together. When I had tested this patch with def_bool, it worked as expected. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/