Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755808Ab3DWI1v (ORCPT ); Tue, 23 Apr 2013 04:27:51 -0400 Received: from LGEMRELSE1Q.lge.com ([156.147.1.111]:53936 "EHLO LGEMRELSE1Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755345Ab3DWI1q (ORCPT ); Tue, 23 Apr 2013 04:27:46 -0400 X-AuditID: 9c93016f-b7c5fae00000791a-8e-51764600241f From: Joonsoo Kim To: Ingo Molnar , Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Srivatsa Vaddagiri , Davidlohr Bueso , Jason Low , Joonsoo Kim Subject: [PATCH v3 2/6] sched: explicitly cpu_idle_type checking in rebalance_domains() Date: Tue, 23 Apr 2013 17:27:38 +0900 Message-Id: <1366705662-3587-3-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1366705662-3587-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1366705662-3587-1-git-send-email-iamjoonsoo.kim@lge.com> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1344 Lines: 36 After commit 88b8dac0, dst-cpu can be changed in load_balance(), then we can't know cpu_idle_type of dst-cpu when load_balance() return positive. So, add explicit cpu_idle_type checking. Cc: Srivatsa Vaddagiri Acked-by: Peter Zijlstra Tested-by: Jason Low Signed-off-by: Joonsoo Kim diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 25aaf93..726e129 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -5523,10 +5523,11 @@ static void rebalance_domains(int cpu, enum cpu_idle_type idle) if (time_after_eq(jiffies, sd->last_balance + interval)) { if (load_balance(cpu, rq, sd, idle, &balance)) { /* - * We've pulled tasks over so either we're no - * longer idle. + * The LBF_SOME_PINNED logic could have changed + * env->dst_cpu, so we can't know our idle + * state even if we migrated tasks. Update it. */ - idle = CPU_NOT_IDLE; + idle = idle_cpu(cpu) ? CPU_IDLE : CPU_NOT_IDLE; } sd->last_balance = jiffies; } -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/