Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756281Ab3DWIgv (ORCPT ); Tue, 23 Apr 2013 04:36:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36244 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755283Ab3DWIgr (ORCPT ); Tue, 23 Apr 2013 04:36:47 -0400 Date: Sat, 20 Apr 2013 15:43:16 +0200 From: Jan Kara To: Lukas Czerner Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH v3 18/18] ext4: Allow punch hole with bigalloc enabled Message-ID: <20130420134316.GB2461@quack.suse.cz> References: <1365498867-27782-1-git-send-email-lczerner@redhat.com> <1365498867-27782-19-git-send-email-lczerner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1365498867-27782-19-git-send-email-lczerner@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1567 Lines: 49 On Tue 09-04-13 11:14:27, Lukas Czerner wrote: > In commits 5f95d21fb6f2aaa52830e5b7fb405f6c71d3ab85 and > 30bc2ec9598a1b156ad75217f2e7d4560efdeeab we've reworked punch_hole > implementation and there is noting holding us back from using punch hole > on file system with bigalloc feature enabled. > > This has been tested with fsx and xfstests. Looks good. You can add: Reviewed-by: Jan Kara Honza > > Signed-off-by: Lukas Czerner > --- > fs/ext4/inode.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 0d452c1..87d6171 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -3536,11 +3536,6 @@ int ext4_punch_hole(struct file *file, loff_t offset, loff_t length) > if (!S_ISREG(inode->i_mode)) > return -EOPNOTSUPP; > > - if (EXT4_SB(sb)->s_cluster_ratio > 1) { > - /* TODO: Add support for bigalloc file systems */ > - return -EOPNOTSUPP; > - } > - > trace_ext4_punch_hole(inode, offset, length); > > /* > -- > 1.7.7.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/