Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755839Ab3DWJGG (ORCPT ); Tue, 23 Apr 2013 05:06:06 -0400 Received: from mga09.intel.com ([134.134.136.24]:8616 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754859Ab3DWJGE (ORCPT ); Tue, 23 Apr 2013 05:06:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,531,1363158000"; d="scan'208";a="299579047" Message-ID: <1366708088.9823.16.camel@sauron.fi.intel.com> Subject: eGalax touchscreen regression From: Artem Bityutskiy Reply-To: artem.bityutskiy@linux.intel.com To: Hui Wang , Dmitry Torokhov Cc: Zhang Jiejing , Hui Wang , linux-input@vger.kernel.org, "linux-kernel@vger.kernel.org" , "Hofemeier, Ulf" Date: Tue, 23 Apr 2013 12:08:08 +0300 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1432 Lines: 40 Hi Dmitry, in the below commit commit ae495e844a77344fdaedbb2ad97d925d096e9f0d Author: Hui Wang Date: Thu Oct 25 00:38:01 2012 -0700 Input: egalax_ts - get gpio from devicetree The irq_to_gpio() is old, most platforms use GENERIC_GPIO framework and don't support this API anymore. The i.MX6q sabrelite platform equips an egalax touchscreen controller, and this platform already transfered to GENERIC_GPIO framework, to support this driver, we use a more generic way to get gpio. Add a return value checking for waking up the controller in the probe function, this guarantee only a workable device can pass init. [dmitry.torokhov@gmail.com: Make driver depend on CONFIG_OF as it is now required.] Acked-by Zhang Jiejing Reviewed-by: Shawn Guo Signed-off-by: Hui Wang Signed-off-by: Dmitry Torokhov the eGalax driver now requires OF. For us this is a regression because we do not have OF: https://bugs.tizen.org/jira/browse/TIVI-740 -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/