Message-id: <1366713461.31792.9.camel@kjgkr>
Subject: Re: [PATCH v4 0/7] f2fs: Add tracepoints support in f2fs filesystem
From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Reply-to: jaegeuk.kim@samsung.com
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: rostedt@goodmis.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Namjae Jeon <namjae.jeon@samsung.com>
Date: Tue, 23 Apr 2013 19:37:41 +0900
In-reply-to: <1366388891-18778-1-git-send-email-linkinjeon@gmail.com>
References: <1366388891-18778-1-git-send-email-linkinjeon@gmail.com>
Organization: samsung
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="=-s6jXqheR4k1b6JtLluht"
MIME-version: 1.0
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3175
Lines: 87


--=-s6jXqheR4k1b6JtLluht
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi, Namjae.

Still I found several inconsistent codes and flaws of information across
the whole patches.
I've finished changing them, so please review the subsequent patches.
Thanks,

2013-04-20 (=ED=86=A0), 01:28 +0900, Namjae Jeon:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>=20
> Add tracepoints in f2fs filesystem for tracing the filesystem
> operations for information/debugging purpose if needed. All the
> tracepoints are clubbed with respect to functionalities.
>=20
> Change Log:
> v4: Modified the tracepoints as per the review comments of
> Jaegeuk Kim. Following tracepoints are added newly:
>=20
> trace_f2fs_truncate_blocks_enter
> trace_f2fs_truncate_blocks_exit
> trace_f2fs_truncate_inode_blocks_enter=20
> trace_f2fs_truncate_inode_blocks_exit
> trace_f2fs_truncate_node
> trace_f2fs_submit_write_page
> trace_f2fs_do_submit_bio
> trace_f2fs_write_checkpoint
>=20
> While some of the tracepoints are modified to add new=20
> parameters.
>=20
> v3: Introduced TRACE_EVENT_CONDITION() macro for checking the
> condition page->mapping inside the trace point function call as
> per Steve's review comment for the patch
>=20
> v2: Added DECLARE_EVENT_CLASS() macro for combining the similar
> type of trace function calls which has same type of arguments.
>=20
> v1: Introduced the tracepoint functions in f2fs filesystem.
>=20
> Namjae Jeon (7):
>   f2fs: add tracepoints for sync & Inode operations
>   f2fs: add tracepoints for truncate operation
>   f2fs: add tracepoint for tracing the page i/o operations
>   f2fs: add tracepoints for GC threads
>   f2fs: add tracepoints to debug the block allocation & fallocate
>   f2fs: add tracepoints for write page operations
>   f2fs: add tracepoints to debug checkpoint request

--=20
Jaegeuk Kim
Samsung

--=-s6jXqheR4k1b6JtLluht
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAABAgAGBQJRdmR1AAoJEEAUqH6CSFDSNnMP/3Rqe07ocHbuHzAFVmePmZPA
knXQr6ZpUotmZLMFamM/4q5CBGVzUdmX+4NjB8rDvpKBx+KBs6lmZu7k/1XEi5p0
7LjV1ybzwTRoAUIMwQ0+6kp1sYYWUXFyohVctwfYszi6hIxPaOu9xcVVvVZZ9P4N
jYgtQil0no0WMw6x9UhMyHoTrHNos+ivLMcsGWv1+0xUxFMH+t+mexgnI7Ds6aWi
AZFe8FBKG66gu3Z9JKAZnNQDZDw7i95F/dJkkMLg6k8dqy9uEQaQmAwWM6GjW51Q
dcGAc+Gdl0+ERdP/QII6+HvcmbpNkqNmBsVi0HMH8qEoWCe7LvzA4xd8hUAT/133
8VE/Nv4IeYZ/XS1YtR9HeWrTFeQe5ctqMk+F4DKrUY8lTjZ4wXWvxEvmASVKuuNo
TaX/LhvnKgKoWm6V4zxrs/VtchRLhG5dvRCEc2/a5FZZ9ffKFeX3zAHn2Dbn7HZU
8Dmq1dZox4HEh0SKx4VDidqn3mcpYJcQSiZFwWoJ2XJ1TCtFpbACf5JPCFAJzhX/
icSCw3s1ZWGFp41HUEgesFex9zKDX69bxuwuSIudLeq3lVuWxh4VFuIvGRbcW4wk
Eh0ZrQemgXHSEV23Z+w/iECFTYpDXndeXeQspuT7Bp9LjxnsK/IyVpEdhKTo3hLd
K1tw9b1oGZV+UhY5aYkR
=yOb/
-----END PGP SIGNATURE-----

--=-s6jXqheR4k1b6JtLluht--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/