Message-id: <1366713631.31792.15.camel@kjgkr>
Subject: Re: [PATCH v4 6/7] f2fs: add tracepoints for write page operations
From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Reply-to: jaegeuk.kim@samsung.com
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: rostedt@goodmis.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Namjae Jeon <namjae.jeon@samsung.com>,
        Pankaj Kumar <pankaj.km@samsung.com>
Date: Tue, 23 Apr 2013 19:40:31 +0900
In-reply-to: <1366388998-18983-1-git-send-email-linkinjeon@gmail.com>
References: <1366388998-18983-1-git-send-email-linkinjeon@gmail.com>
Organization: samsung
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="=-nQLx5z6CguMWGgKOfytf"
MIME-version: 1.0
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 5442
Lines: 185


--=-nQLx5z6CguMWGgKOfytf
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

=46rom 6ec178dac6768204a6edf70f4a53d40b691c12b4 Mon Sep 17 00:00:00 2001
From: Namjae Jeon <namjae.jeon@samsung.com>
Date: Tue, 23 Apr 2013 17:51:43 +0900
Subject: [PATCH 6/7] f2fs: add tracepoints for write page operations
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net

Add tracepoints to debug the various page write operation
like data pages, meta pages.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Pankaj Kumar <pankaj.km@samsung.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
[Jaegeuk: remove unnecessary tracepoints]
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
---
 fs/f2fs/segment.c           |  5 ++++
 include/trace/events/f2fs.h | 67
+++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 72 insertions(+)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 7c67ec2..0a65284 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -18,6 +18,7 @@
 #include "f2fs.h"
 #include "segment.h"
 #include "node.h"
+#include <trace/events/f2fs.h>
=20
 /*
  * This function balances dirty node and dentry pages.
@@ -691,6 +692,9 @@ static void do_submit_bio(struct f2fs_sb_info *sbi,
 		struct bio_private *p =3D sbi->bio[btype]->bi_private;
 		p->sbi =3D sbi;
 		sbi->bio[btype]->bi_end_io =3D f2fs_end_io_write;
+
+		trace_f2fs_do_submit_bio(sbi->sb, btype, sync, sbi->bio[btype]);
+
 		if (type =3D=3D META_FLUSH) {
 			DECLARE_COMPLETION_ONSTACK(wait);
 			p->is_sync =3D true;
@@ -745,6 +749,7 @@ alloc_new:
 	sbi->last_block_in_bio[type] =3D blk_addr;
=20
 	up_write(&sbi->bio_sem);
+	trace_f2fs_submit_write_page(page, blk_addr, type);
 }
=20
 static bool __has_curseg_space(struct f2fs_sb_info *sbi, int type)
diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
index 56b6240..ae2da92 100644
--- a/include/trace/events/f2fs.h
+++ b/include/trace/events/f2fs.h
@@ -8,6 +8,14 @@
=20
 #define show_dev(entry)		MAJOR(entry->dev), MINOR(entry->dev)
 #define show_dev_ino(entry)	show_dev(entry), (unsigned long)entry->ino
+
+#define show_block_type(type)						\
+	__print_symbolic(type,						\
+		{ NODE,		"NODE" },				\
+		{ DATA,		"DATA" },				\
+		{ META,		"META" },				\
+		{ META_FLUSH,	"META_FLUSH" })
+
 #define show_bio_type(type)						\
 	__print_symbolic(type,						\
 		{ READ, 	"READ" },				\
@@ -578,6 +586,65 @@ TRACE_EVENT(f2fs_reserve_new_block,
 		__entry->ofs_in_node)
 );
=20
+TRACE_EVENT(f2fs_do_submit_bio,
+
+	TP_PROTO(struct super_block *sb, int btype, bool sync, struct bio
*bio),
+
+	TP_ARGS(sb, btype, sync, bio),
+
+	TP_STRUCT__entry(
+		__field(dev_t,	dev)
+		__field(int,	btype)
+		__field(bool,	sync)
+		__field(sector_t,	sector)
+		__field(unsigned int,	size)
+	),
+
+	TP_fast_assign(
+		__entry->dev		=3D sb->s_dev;
+		__entry->btype		=3D btype;
+		__entry->sync		=3D sync;
+		__entry->sector		=3D bio->bi_sector;
+		__entry->size		=3D bio->bi_size;
+	),
+
+	TP_printk("dev =3D (%d,%d), type =3D %s, io =3D %s, sector =3D %lld, size=
 =3D %
u",
+		show_dev(__entry),
+		show_block_type(__entry->btype),
+		__entry->sync ? "sync" : "no sync",
+		(unsigned long long)__entry->sector,
+		__entry->size)
+);
+
+TRACE_EVENT(f2fs_submit_write_page,
+
+	TP_PROTO(struct page *page, block_t blk_addr, int type),
+
+	TP_ARGS(page, blk_addr, type),
+
+	TP_STRUCT__entry(
+		__field(dev_t,	dev)
+		__field(ino_t,	ino)
+		__field(int, type)
+		__field(pgoff_t, index)
+		__field(block_t, block)
+	),
+
+	TP_fast_assign(
+		__entry->dev	=3D page->mapping->host->i_sb->s_dev;
+		__entry->ino	=3D page->mapping->host->i_ino;
+		__entry->type	=3D type;
+		__entry->index	=3D page->index;
+		__entry->block	=3D blk_addr;
+	),
+
+	TP_printk("dev =3D (%d,%d), ino =3D %lu, %s, index =3D %lu, blkaddr =3D 0=
x%
llx",
+		show_dev_ino(__entry),
+		show_block_type(__entry->type),
+		(unsigned long)__entry->index,
+		(unsigned long long)__entry->block)
+);
+
 #endif /* _TRACE_F2FS_H */
=20
  /* This part must be outside protection */
--=20
1.8.1.3.566.gaa39828


--=20
Jaegeuk Kim
Samsung

--=-nQLx5z6CguMWGgKOfytf
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAABAgAGBQJRdmUfAAoJEEAUqH6CSFDSQsoP/jp4HaAMyckJHKPDCf/1nYoV
WqITfPx7JQXXijiUa3krlQX027/oPkopuUteWQu5Kfl1Q6iUSPXgs/XCTbrN3czy
FYYiQF5YjrbhN6HWpJpefXwoms2yF/2H/sQs8gHZy/KBJjynTWJAU+OED9hiZB/R
1nrLFfbMS2LW6hFBz+YbpUrJZzO7mAg1kMX9CaUNSCJ//yn9dPnyQ7QjSN8gyimS
RlMxHMzLRS5JeWUjfUFgBJHTwdWzEbAbP00k9qLw9NxV17JJzb0PQJa9DTgfr8W6
epjol5k1ztd0EO6fymSSUJRI1tptbkJ57LsAFsdn0Ne5aPrUG+unhENoEjK3yOAy
1HupAggLP9aGQe875ujvjydS3wl9/YsFKmPyRtZJJwEPt5nsP0/KhYf09MS0LwVB
lbz92DavY3cOBAu/k46ex1kg9eB5dLfLfVRD+CAcMf5ecgm+1nNO6cmsezMkzUsD
rby3Nx0h1nxaEFPi92azbLi8ARVR2T0M/LeU8q6EV9KZM5s3+GbINiirV9UW9KAG
z0SIA3lpw4tkY87F0IsCf/cjXKoa6UbrPwSdbg6ASd1j5p0Gb/Hugkta3QLfMa1N
RbAUcJhvROu+WtFHItsyHJLRWd7QLGT4sPmRhMvYii7mIsRxLAHQBItAp6gv35RY
tVijnG4lyG37dWhHuWub
=wAFP
-----END PGP SIGNATURE-----

--=-nQLx5z6CguMWGgKOfytf--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/