Message-id: <1366713655.31792.16.camel@kjgkr>
Subject: Re: [PATCH v4 7/7] f2fs: add tracepoints to debug checkpoint request
From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Reply-to: jaegeuk.kim@samsung.com
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: rostedt@goodmis.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Namjae Jeon <namjae.jeon@samsung.com>,
        Pankaj Kumar <pankaj.km@samsung.com>
Date: Tue, 23 Apr 2013 19:40:55 +0900
In-reply-to: <1366389010-19017-1-git-send-email-linkinjeon@gmail.com>
References: <1366389010-19017-1-git-send-email-linkinjeon@gmail.com>
Organization: samsung
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="=-79Sn5JKXRf9uosJPqNJl"
MIME-version: 1.0
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 4193
Lines: 135


--=-79Sn5JKXRf9uosJPqNJl
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

=46rom 2af4bd6ca556d690ee166200abd16fdbe749782e Mon Sep 17 00:00:00 2001
From: Namjae Jeon <namjae.jeon@samsung.com>
Date: Tue, 23 Apr 2013 18:26:54 +0900
Subject: [PATCH 7/7] f2fs: add tracepoints to debug checkpoint request
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net

Add tracepoints to debug checkpoint request.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Pankaj Kumar <pankaj.km@samsung.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
[Jaegeuk: change expressions]
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
---
 fs/f2fs/checkpoint.c        |  7 +++++++
 include/trace/events/f2fs.h | 24 ++++++++++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index be6aa2e..f54b83b 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -20,6 +20,7 @@
 #include "f2fs.h"
 #include "node.h"
 #include "segment.h"
+#include <trace/events/f2fs.h>
=20
 static struct kmem_cache *orphan_entry_slab;
 static struct kmem_cache *inode_entry_slab;
@@ -714,9 +715,13 @@ void write_checkpoint(struct f2fs_sb_info *sbi,
bool is_umount)
 	struct f2fs_checkpoint *ckpt =3D F2FS_CKPT(sbi);
 	unsigned long long ckpt_ver;
=20
+	trace_f2fs_write_checkpoint(sbi->sb, is_umount, "start block_ops");
+
 	mutex_lock(&sbi->cp_mutex);
 	block_operations(sbi);
=20
+	trace_f2fs_write_checkpoint(sbi->sb, is_umount, "finish block_ops");
+
 	f2fs_submit_bio(sbi, DATA, true);
 	f2fs_submit_bio(sbi, NODE, true);
 	f2fs_submit_bio(sbi, META, true);
@@ -738,6 +743,8 @@ void write_checkpoint(struct f2fs_sb_info *sbi, bool
is_umount)
=20
 	unblock_operations(sbi);
 	mutex_unlock(&sbi->cp_mutex);
+
+	trace_f2fs_write_checkpoint(sbi->sb, is_umount, "finish checkpoint");
 }
=20
 void init_orphan_info(struct f2fs_sb_info *sbi)
diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
index ae2da92..b2b2f72 100644
--- a/include/trace/events/f2fs.h
+++ b/include/trace/events/f2fs.h
@@ -645,6 +645,30 @@ TRACE_EVENT(f2fs_submit_write_page,
 		(unsigned long long)__entry->block)
 );
=20
+TRACE_EVENT(f2fs_write_checkpoint,
+
+	TP_PROTO(struct super_block *sb, bool is_umount, char *msg),
+
+	TP_ARGS(sb, is_umount, msg),
+
+	TP_STRUCT__entry(
+		__field(dev_t,	dev)
+		__field(bool,	is_umount)
+		__field(char *,	msg)
+	),
+
+	TP_fast_assign(
+		__entry->dev		=3D sb->s_dev;
+		__entry->is_umount	=3D is_umount;
+		__entry->msg		=3D msg;
+	),
+
+	TP_printk("dev =3D (%d,%d), checkpoint for %s, state =3D %s",
+		show_dev(__entry),
+		__entry->is_umount ? "clean umount" : "consistency",
+		__entry->msg)
+);
+
 #endif /* _TRACE_F2FS_H */
=20
  /* This part must be outside protection */
--=20
1.8.1.3.566.gaa39828


--=20
Jaegeuk Kim
Samsung

--=-79Sn5JKXRf9uosJPqNJl
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAABAgAGBQJRdmU4AAoJEEAUqH6CSFDSrWoQAI0bGu2bKu346DPbO9GUqimd
syIdwnaaMBraoTBc4yWr0CkUYR5zUTIPKicCH0C3SSH5lboxwEpET8QmzHtcpiVk
BZyVoYuGtpkTHoBlH+wJh+7sQeIzt4QDJpafz+R6nq9nuiKSHTCpEYPqLxjpaprT
JLYUMB3mw/s7V4JoPVoRiuBEBeSPRylxLwlj3EcaMsncxC/JBObeQWkuUqYSRf4e
5r2g3fP+3z/gfbUaloNdAG2/r8OVezDrShJRGTcG6re7l7qa19opygWWQbgKh/o3
okzlLNvY+M61PhPnfCwwEkPdineK/WMCCAwytBNyTLZ3DYf5OIHdofpmDci7mpeL
krGlupXdBxxkUxyAFVHyUsHAInz6G0LZY4GW+meyNavXkcoUVyMD+zJL6vAK0F7s
Dh+j6NCrGM/VADX+Aws5NIInpSnhvnZOkFjmnLhpXRYvs1KFGPtebhTNTifqE63n
nFJ74Sojotb7N0gutBl7z3svqGAkVDoiNZNOhP5RMNKdEHRzIlO1CLdEbVFKtbwB
OPc6HIYo/a/aBflG338DFYXs7w6Q2ixlm99CcLCHVrTdDJOoAql+3K4F6NsbVx/D
YMbJrtbLshQbsO1tFH5vEZAgZ0mmU5ajbmxZAA3aQE17WxNHMSNaGpNlLHgX2u5B
Q5Z8bj8PLcJsTo5gqDLL
=MVC2
-----END PGP SIGNATURE-----

--=-79Sn5JKXRf9uosJPqNJl--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/