Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755271Ab3DWOCN (ORCPT ); Tue, 23 Apr 2013 10:02:13 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:61327 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754936Ab3DWOCL (ORCPT ); Tue, 23 Apr 2013 10:02:11 -0400 MIME-Version: 1.0 In-Reply-To: <5171808B.1010209@gmail.com> References: <1366378725-14471-1-git-send-email-michal.bachraty@streamunlimited.com> <5171808B.1010209@gmail.com> Date: Tue, 23 Apr 2013 16:02:10 +0200 Message-ID: Subject: Re: [PATCH 1/2] ALSA: ASoc: spdif_transciever: Add DT support From: Sebastian Hesselbarth To: Daniel Mack Cc: Michal Bachraty , alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.de, devicetree-discuss@lists.ozlabs.org, Mark Brown , linux-kernel@vger.kernel.org, Rob Herring , perex@perex.cz, marek.belisko@streamunlimited.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1611 Lines: 49 On Fri, Apr 19, 2013 at 7:36 PM, Daniel Mack wrote: > Hi Michal, > > On 19.04.2013 15:38, Michal Bachraty wrote: >> Add devicetree support for this dummy audio soc driver. > > I think Mark wants to see only "ASoC:" in the patch subjects now. > >> >> Signed-off-by: Michal Bachraty >> --- >> sound/soc/codecs/spdif_transciever.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/sound/soc/codecs/spdif_transciever.c b/sound/soc/codecs/spdif_transciever.c >> index 112a49d..4c8c295 100644 >> --- a/sound/soc/codecs/spdif_transciever.c >> +++ b/sound/soc/codecs/spdif_transciever.c >> @@ -20,6 +20,7 @@ >> #include >> #include >> #include >> +#include >> >> #define DRV_NAME "spdif-dit" >> >> @@ -52,12 +53,21 @@ static int spdif_dit_remove(struct platform_device *pdev) >> return 0; >> } >> >> +#ifdef CONFIG_OF >> +static const struct of_device_id spdif_dit_dt_ids[] = { >> + { .compatible = DRV_NAME, }, > > I think this needs a "linux," prefix. Just put the whole string here. Michal, I suggest to also rename spdif_transceiver to spdif_transmitter, as "transceiver" usually do both "transmit" and "receive". I don't know who made up the current name, but the driver is definitely a transmitter. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/