Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756899Ab3DWPkO (ORCPT ); Tue, 23 Apr 2013 11:40:14 -0400 Received: from mail-da0-f54.google.com ([209.85.210.54]:49526 "EHLO mail-da0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756488Ab3DWPkL (ORCPT ); Tue, 23 Apr 2013 11:40:11 -0400 Date: Tue, 23 Apr 2013 08:40:07 -0700 From: Dmitry Torokhov To: Artem Bityutskiy Cc: Hui Wang , Zhang Jiejing , linux-input@vger.kernel.org, "linux-kernel@vger.kernel.org" , "Hofemeier, Ulf" Subject: Re: eGalax touchscreen regression Message-ID: <20130423154007.GB4104@core.coreip.homeip.net> References: <1366708088.9823.16.camel@sauron.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366708088.9823.16.camel@sauron.fi.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1820 Lines: 49 Hi Artem, On Tue, Apr 23, 2013 at 12:08:08PM +0300, Artem Bityutskiy wrote: > Hi Dmitry, > > in the below commit > > commit ae495e844a77344fdaedbb2ad97d925d096e9f0d > Author: Hui Wang > Date: Thu Oct 25 00:38:01 2012 -0700 > > Input: egalax_ts - get gpio from devicetree > > The irq_to_gpio() is old, most platforms use GENERIC_GPIO framework > and don't support this API anymore. > > The i.MX6q sabrelite platform equips an egalax touchscreen controller, > and this platform already transfered to GENERIC_GPIO framework, to > support this driver, we use a more generic way to get gpio. > > Add a return value checking for waking up the controller in the probe > function, this guarantee only a workable device can pass init. > > [dmitry.torokhov@gmail.com: Make driver depend on CONFIG_OF as it is > now required.] > > Acked-by Zhang Jiejing > Reviewed-by: Shawn Guo > Signed-off-by: Hui Wang > Signed-off-by: Dmitry Torokhov > > the eGalax driver now requires OF. For us this is a regression because > we do not have OF: https://bugs.tizen.org/jira/browse/TIVI-740 I see. In this case we need to come up with a platform data to pass wakeup gpio in case platform does not support OF. irq_to_gpio() is not supported on many platforms, causing compilation errors. Is the platform that you are trying to use the touchscreen upstream? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/