Message-ID: <1366732681.9609.157.camel@gandalf.local.home>
Subject: Re: [RFC 00/14] perf tools: Introduce new 'ftrace' command
From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung.kim@lge.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Frederic Weisbecker <fweisbec@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
        David Ahern <dsahern@gmail.com>, Stephane Eranian <eranian@google.com>
Date: Tue, 23 Apr 2013 11:58:01 -0400
In-Reply-To: <1366705872-12132-1-git-send-email-namhyung@kernel.org>
References: <1366705872-12132-1-git-send-email-namhyung@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1400
Lines: 37

On Tue, 2013-04-23 at 17:30 +0900, Namhyung Kim wrote:
> Hello,
> 
> This patchset implements a front-end tool for kernel's ftrace.  It
> uses function_graph tracer by default and normal function tracer is
> also supported.  (Of course you need to enable those tracers in your
> kernel first.)
> 
> NOTE: It's in very early stage, so may contain many rough edges.
> 

Very nice Namhyung, thanks for doing this. I did a quick run through of
the patches and I have no complaints about them. I'm not sure how the
others will feel about it.

Also, have you given thought on how to execute both ftrace and the pmu
counters? That is, to get a way to interleave the data?

I added a 'perf' clock to ftrace. I didn't see that being checked,
although I didn't look too hard. If possible, you can use that, as well
as the multi-buffers that are coming in 3.10.

I would also like to add a system call to allow you to get to the ftrace
data without the need for debugfs. I'm not sure if we should piggy back
on the perf system call, or add a new one. I'm thinking we should add a
new one so that it doesn't get too confusing.

Hope others have comments,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/