Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756931Ab3DWSAA (ORCPT ); Tue, 23 Apr 2013 14:00:00 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:60116 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756714Ab3DWR77 (ORCPT ); Tue, 23 Apr 2013 13:59:59 -0400 Message-ID: <1366739994.2036.1.camel@joe-AO722> Subject: Re: [PATCH] mtd: Convert logging messages From: Joe Perches To: =?ISO-8859-1?Q?J=F6rn?= Engel Cc: Joern Engel , David Woodhouse , linux-mtd@lists.infradead.org, LKML Date: Tue, 23 Apr 2013 10:59:54 -0700 In-Reply-To: <20130422143118.GA12908@logfs.org> References: <1366394375.3901.36.camel@joe-AO722> <20130419165516.GA19480@logfs.org> <1366396053.3901.40.camel@joe-AO722> <20130422143118.GA12908@logfs.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.2-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1405 Lines: 37 On Mon, 2013-04-22 at 10:31 -0400, J?rn Engel wrote: > On Fri, 19 April 2013 11:27:33 -0700, Joe Perches wrote: > > On Fri, 2013-04-19 at 12:55 -0400, J?rn Engel wrote: > > > On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote: > > > > } > > > > list_add(&dev->list, &blkmtd_device_list); > > > > - INFO("mtd%d: [%s] erase_size = %dKiB [%d]", dev->mtd.index, > > > > - dev->mtd.name + strlen("block2mtd: "), > > > > - dev->mtd.erasesize >> 10, dev->mtd.erasesize); > > > > + pr_info("mtd%d: [%s] erase_size = %dKiB [%d]\n", > > > > + dev->mtd.index, > > > > + dev->mtd.name + strlen("block2mtd: "), > > > > + dev->mtd.erasesize >> 10, dev->mtd.erasesize); > > > > > > I personally dislike the indent-to-braces style because it causes > > > unnecessary churn in patches like this. > > > > It comes from an automated emacs conversion. > > Then please teach your emacs to be a better tool. Because you personally dislike something isn't enough of a reason for me to change my tools nor enough of a reason for me to add a special exception to my tools for your preferences. > I trust you are smart enough to do that. Snide much? cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/