Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756953Ab3DWSD0 (ORCPT ); Tue, 23 Apr 2013 14:03:26 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:42749 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755933Ab3DWSDZ (ORCPT ); Tue, 23 Apr 2013 14:03:25 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX185/6gxZxmhIc45lyUyhtwo Date: Tue, 23 Apr 2013 11:03:20 -0700 From: Tony Lindgren To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, David Woodhouse , Artem Bityutskiy , Afzal Mohammed , Russell King , linux-mtd@lists.infradead.org Subject: Re: [PATCH 21/21] mtd: omap2: allow bulding as a module Message-ID: <20130423180320.GJ10155@atomide.com> References: <1366734653-488286-1-git-send-email-arnd@arndb.de> <1366734653-488286-22-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366734653-488286-22-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1755 Lines: 48 * Arnd Bergmann [130423 09:37]: > The omap2 nand device driver calls into the the elm code, which can > be a loadable module, and in that case it cannot be built-in itself. > I can see no reason why the omap2 driver cannot also be a module, > so let's make the option "tristate" in Kconfig to fix this allmodconfig > build error: > > ERROR: "elm_config" [drivers/mtd/nand/omap2.ko] undefined! > ERROR: "elm_decode_bch_error_page" [drivers/mtd/nand/omap2.ko] undefined! > > Signed-off-by: Arnd Bergmann > Cc: David Woodhouse > Cc: Artem Bityutskiy > Cc: Tony Lindgren > Cc: Afzal Mohammed > Cc: Russell King > Cc: linux-mtd@lists.infradead.org > --- > drivers/mtd/nand/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index 81bf5e5..106b55e 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -109,7 +109,7 @@ config MTD_NAND_OMAP2 > > config MTD_NAND_OMAP_BCH > depends on MTD_NAND && MTD_NAND_OMAP2 && ARCH_OMAP3 > - bool "Enable support for hardware BCH error correction" > + tristate "Enable support for hardware BCH error correction" > default n > select BCH > select BCH_CONST_PARAMS Acked-by: Tony Lindgren While at it, you could also drop the "default n" as that's the default anyways. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/