From: Arnd Bergmann <arnd@arndb.de>
To: Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 18/21] usb: phy: tegra: don't call into tegra-ehci directly
Date: Tue, 23 Apr 2013 21:02:20 +0200
User-Agent: KMail/1.12.2 (Linux/3.8.0-18-generic; KDE/4.3.2; x86_64; ; )
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Venu Byravarasu <vbyravarasu@nvidia.com>, Felipe Balbi <balbi@ti.com>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Stephen Warren <swarren@nvidia.com>, linux-usb@vger.kernel.org
References: <Pine.LNX.4.44L0.1304231239220.1679-100000@iolanthe.rowland.org>
In-Reply-To: <Pine.LNX.4.44L0.1304231239220.1679-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201304232102.20573.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1036
Lines: 32

On Tuesday 23 April 2013, Alan Stern wrote:
> On Tue, 23 Apr 2013, Arnd Bergmann wrote:

> > @@ -733,7 +731,9 @@ static int tegra_ehci_probe(struct platform_device *pdev)
> >  
> >  	tegra->phy = tegra_usb_phy_open(&pdev->dev, instance, hcd->regs,
> >  					pdata->phy_config,
> > -					TEGRA_USB_PHY_MODE_HOST);
> > +					TEGRA_USB_PHY_MODE_HOST,
> > +					&tegra_ehci_set_pts,
> > +					tegra_ehci_set_phcd);
> 
> Does the compiler warn about the unnecessary '&'? 

No, AFAIK, both variants are equally acceptable C.

> In any case, it
> looks strange to have one function pointer with an '&' and another
> without.

Yes, that was certainly not intentional. I've removed the '&' now.

> Aside from that minor detail, the ehci-tegra.c changes are fine.

Ok, thanks for the feedback.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/